From f98ecdf45949dd2df0c1d3de5908fc93350fd72c Mon Sep 17 00:00:00 2001 From: meawong Date: Tue, 17 Feb 2026 15:46:07 -0800 Subject: [PATCH 1/2] 31296 - Update correction output logic and tests --- legal-api/src/legal_api/core/meta/filing.py | 8 ++++---- .../v2/test_business_filings/test_filing_documents.py | 5 ----- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/legal-api/src/legal_api/core/meta/filing.py b/legal-api/src/legal_api/core/meta/filing.py index 75d209e914..2382083e08 100644 --- a/legal-api/src/legal_api/core/meta/filing.py +++ b/legal-api/src/legal_api/core/meta/filing.py @@ -1012,8 +1012,8 @@ def alter_outputs_correction(filing, business, outputs): if correction.get("commentOnly") and business.legal_type in Business.CORPS: if not correction.get("correctionBenStatement"): # BEN correction statement require NOA outputs.remove("noticeOfArticles") - else: - corrected_filing_type = filing.filing_json["filing"].get("correction", {}).get("correctedFilingType") + if correction.get("toLegalName"): + corrected_filing_type = filing.meta_data.get("correction", {}).get("correctedFilingType") if corrected_filing_type == "amalgamationApplication": outputs.add("certificateOfAmalgamation") elif corrected_filing_type == "continuationIn": @@ -1023,9 +1023,9 @@ def alter_outputs_correction(filing, business, outputs): business.legal_type != Business.LegalTypes.COOP.value ): outputs.add("certificateOfIncorporation") + elif business.legal_type == Business.LegalTypes.COOP.value: + outputs.add("certificateOfNameCorrection") - if correction.get("toLegalName") and business.legal_type == Business.LegalTypes.COOP.value: - outputs.add("certificateOfNameCorrection") if correction.get("uploadNewRules"): outputs.add("certifiedRules") if correction.get("uploadNewMemorandum"): diff --git a/legal-api/tests/unit/resources/v2/test_business_filings/test_filing_documents.py b/legal-api/tests/unit/resources/v2/test_business_filings/test_filing_documents.py index 15d1680895..8b002f28ba 100644 --- a/legal-api/tests/unit/resources/v2/test_business_filings/test_filing_documents.py +++ b/legal-api/tests/unit/resources/v2/test_business_filings/test_filing_documents.py @@ -270,7 +270,6 @@ def test_unpaid_filing(session, client, jwt): {'documents': { 'receipt': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/receipt', 'noticeOfArticles': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/noticeOfArticles', - 'certificateOfIncorporation': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/certificateOfIncorporation', 'legalFilings': [ {'correction': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/correction'} ] @@ -283,7 +282,6 @@ def test_unpaid_filing(session, client, jwt): {'documents': { 'receipt': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/receipt', 'noticeOfArticles': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/noticeOfArticles', - 'certificateOfIncorporation': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/certificateOfIncorporation', 'legalFilings': [ {'correction': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/correction'} ] @@ -296,7 +294,6 @@ def test_unpaid_filing(session, client, jwt): {'documents': { 'receipt': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/receipt', 'noticeOfArticles': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/noticeOfArticles', - 'certificateOfIncorporation': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/certificateOfIncorporation', 'legalFilings': [ {'correction': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/correction'} ] @@ -309,7 +306,6 @@ def test_unpaid_filing(session, client, jwt): {'documents': { 'receipt': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/receipt', 'noticeOfArticles': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/noticeOfArticles', - 'certificateOfIncorporation': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/certificateOfIncorporation', 'legalFilings': [ {'correction': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/correction'} ] @@ -322,7 +318,6 @@ def test_unpaid_filing(session, client, jwt): {'documents': { 'receipt': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/receipt', 'noticeOfArticles': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/noticeOfArticles', - 'certificateOfIncorporation': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/certificateOfIncorporation', 'legalFilings': [ {'correction': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/correction'} ] From f083545911b42b59484a8e9e223976554c0012ad Mon Sep 17 00:00:00 2001 From: meawong Date: Tue, 17 Feb 2026 16:13:10 -0800 Subject: [PATCH 2/2] 31296 - lint fix --- legal-api/src/legal_api/core/meta/filing.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/legal-api/src/legal_api/core/meta/filing.py b/legal-api/src/legal_api/core/meta/filing.py index 2382083e08..5573641602 100644 --- a/legal-api/src/legal_api/core/meta/filing.py +++ b/legal-api/src/legal_api/core/meta/filing.py @@ -1009,9 +1009,12 @@ def alter_outputs_correction(filing, business, outputs): """Handle output file list modification for corrections.""" if filing.filing_type == "correction": correction = filing.meta_data.get("correction", {}) - if correction.get("commentOnly") and business.legal_type in Business.CORPS: - if not correction.get("correctionBenStatement"): # BEN correction statement require NOA - outputs.remove("noticeOfArticles") + if ( + correction.get("commentOnly") and + business.legal_type in Business.CORPS and + not correction.get("correctionBenStatement") # BEN correction statement require NOA + ): + outputs.remove("noticeOfArticles") if correction.get("toLegalName"): corrected_filing_type = filing.meta_data.get("correction", {}).get("correctedFilingType") if corrected_filing_type == "amalgamationApplication":