Skip to content

[bug] lingering github check status on reruns #945

Description

@OmarTawfik

Thanks for working on Bencher!

The new GitHub checks feature has been really useful, but unfortunately it only updates the check status once it completes. has a few issues:

  • When the test job reruns (user pushes to the PR branch), a failure/success status lingers until the run is complete, giving false reading in the meantime.
  • If the test job was cancelled/stopped for any reason, the old failure/success is left reported on the PR.
  • This issue worsens for long-running/slow benchmarks (like callgrind/gangraun) that can take up to 1~2 hours to finish.

I suggest setting the GitHub check status to in_progress before running the benchmark, so that the status is reflected accordingly until results are ready.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions