Added Locale functionality#58
Open
frandemona wants to merge 6 commits into
Open
Conversation
Owner
|
Hi, thank you for making this PR. Unfortunately, I don't have the time these days to review it or maintain the library in general. Sorry about that! |
Author
|
No problem. Thanks for the project though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to make it with dynamic imports but I was having a webpack error it's in the test branch over at my repo. For now I've left it to be able to choose spanish or english as a locale, which was the functionality I was looking for. I didn't add any more locales add I wanted to maintain the library lean.
Thanks!