Skip to content

RBF docs mix BIP 125 and Bitcoin Core policy #52

Description

@noahjoeris

The RBF docs/comments currently mix BIP 125 rule numbers and Bitcoin Core's mempool-replacements.md wording as if they were the same spec.

Bitcoin Core's replacement policy has diverged from BIP 125 over time:

  • Rule 1: Removed in Core policy: full RBF default in v28.0; -mempoolfullrbf removed in v29.0
  • Rule 2: Removed in Core policy in v31.0.
  • Rule 3: Unchanged.
  • Rule 4: Changed in Core policy to use -incrementalrelayfee
  • Rule 5: Changed in Core policy in v31.0.
  • Rule 6: Core-only rule; changed in Core policy in v31.0.

This makes several comments ambiguous or factually wrong depending on which policy/version the reader assumes.

Examples

Possible fix

  • Follow a specific Bitcoin Core policy version and link to tagged Core docs instead of master
  • Document any behavior that intentionally differs from that pinned Core policy, e.g. stricter BIP 125 checks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussionDiscussiondocumentationImprovements or additions to documentation

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions