fix frame payment renderer component#16
Open
PanMisza wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
Fixes a payment renderer component issue in Magento's checkout process by changing the base component from uiComponent to Magento_Checkout/js/view/payment/default. This resolves an error that occurs when switching delivery methods after selecting a bluepayment payment method.
- Change component base class for
bluepayment-prependandbluepayment-appendrenderers - Ensures proper lifecycle method availability (
disposeSubscriptions) required by Magento's payment list component
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Magento w pewnych sytuacjach wymaga aby payment renderer miało metody, których
bluepayment-prependibluepayment-appendnie mają.Przykładowy scenariusz, zakładający że żadna z metod płatności bluepayment nie jest dostępna dla metod dostawy za pobraniem:
Użytkownik nie może przejść dalej, a w konsoli zobaczymy błąd z
magento/module-checkout/view/frontend/web/js/view/payment/list.js[removeRenderer] - wykonywane jest tam na naszych rendererachdisposeSubscriptions(), a takiej metody nie mamy.Zmieniłem komponent tych rendererów z
uiComponentnaMagento_Checkout/js/view/payment/defaulti to rozwiązuje ten problem.