ci: add tamirdresher to CHANGELOG Write Protection allowlist#1220
Merged
tamirdresher merged 1 commit intoJun 7, 2026
Merged
Conversation
Allows tamirdresher (co-maintainer per CODEOWNERS in PR bradygaster#1217) to drive release PRs that modify CHANGELOG.md directly, matching established repo convention (PR bradygaster#1023 — chore: release v0.9.4 — was tamirdresher-authored). Without this change, every release PR from tamirdresher requires admin merge override on the CHANGELOG Write Protection gate (see PRs bradygaster#1218, bradygaster#1219 for v0.10.0). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 10 check(s) still running |
Files Changed (1 file, +1 −1)
| File | +/− |
|---|---|
.github/workflows/squad-ci.yml |
+1 −1 |
Total: +1 −1
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
🟢 Impact Analysis — PR #1220Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
🏗️ Architectural Review
Automated architectural review — informational only. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Squad CI workflow’s “CHANGELOG Write Protection” gate to recognize tamirdresher as an approved author for direct CHANGELOG.md edits, reducing release PR friction while keeping the allowlist-based protection model intact.
Changes:
- Adds
tamirdresherto theAPPROVED_AUTHORSallowlist used by the CHANGELOG write-protection gate.
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
tamirdresherto CHANGELOG Write Protection allowlist.github/workflows/squad-ci.yml:254—APPROVED_AUTHORSfor the "CHANGELOG Write Protection" gate currently allows onlybradygaster,github-actions[bot], andcopilot-swe-agent[bot]. Every release PR I drive (e.g. v0.9.4 in PR #1023, today's v0.10.0 in #1218 + #1219) modifiesCHANGELOG.mddirectly and trips this gate, requiring admin merge override each time.Adding
tamirdresheras a fourth approved author matches established convention:Why this PR doesn't trip the gate itself
This PR doesn't touch
CHANGELOG.md(only the workflow file), so the "CHANGELOG Write Protection" gate is inactive. Should pass cleanly through the normal "Gate: Changelog" check too — no SDK/CLI source modified.Rebase plan
Once this lands on dev, I'll rebase PR #1219 (dev → main promote for v0.10.0) on top, and CI will pass without admin override.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com