From 5f2479dd02bc72a43ac10a867b732e176c12cfb4 Mon Sep 17 00:00:00 2001 From: Stefan VanBuren Date: Fri, 8 Aug 2025 14:25:32 -0400 Subject: [PATCH 1/3] Remove Go 1.22 workflow in CI We bumped to Go 1.23 support in https://github.com/bufbuild/bufplugin-go/pull/14, so we don't need to run our workflow on an unsupported version. Just run based on the go version in go.mod. --- .github/workflows/ci.yaml | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 8d0800f..ff03952 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -13,9 +13,6 @@ permissions: jobs: ci: runs-on: ubuntu-latest - strategy: - matrix: - go-version: [1.22.x, 1.23.x] steps: - name: Checkout Code uses: actions/checkout@v4 @@ -24,13 +21,8 @@ jobs: - name: Install Go uses: actions/setup-go@v5 with: - go-version: ${{ matrix.go-version }} + go-version-file: go.mod - name: Test run: make test - name: Lint - # Often, lint & gofmt guidelines depend on the Go version. To prevent - # conflicting guidance, run only on the most recent supported version. - # For the same reason, only check generated code on the most recent - # supported version. - if: matrix.go-version == '1.23.x' run: make checkgenerate && make lint From 19c73d8682c131828e6e12086274c8f914f1ec87 Mon Sep 17 00:00:00 2001 From: Stefan VanBuren Date: Thu, 14 Aug 2025 09:42:55 -0400 Subject: [PATCH 2/3] Add back matrix tests, up to 1.25 --- .github/workflows/ci.yaml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index ff03952..e448c97 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -13,6 +13,9 @@ permissions: jobs: ci: runs-on: ubuntu-latest + strategy: + matrix: + go-version: [1.23.x, 1.24.x, 1.25.x] steps: - name: Checkout Code uses: actions/checkout@v4 @@ -21,8 +24,13 @@ jobs: - name: Install Go uses: actions/setup-go@v5 with: - go-version-file: go.mod + go-version: ${{ matrix.go-version }} - name: Test run: make test - name: Lint + # Often, lint & gofmt guidelines depend on the Go version. To prevent + # conflicting guidance, run only on the most recent supported version. + # For the same reason, only check generated code on the most recent + # supported version. + if: matrix.go-version == '1.25.x' run: make checkgenerate && make lint From b6673e70a37ca0dc76f1c5a404539ee27d266d77 Mon Sep 17 00:00:00 2001 From: Stefan VanBuren Date: Fri, 29 Aug 2025 12:20:38 -0400 Subject: [PATCH 3/3] Pin protocolbuffers/go in check/internal/example Otherwise, we have churn in CI due to the generated files changing. --- check/internal/example/buf.gen.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/check/internal/example/buf.gen.yaml b/check/internal/example/buf.gen.yaml index edbfc67..0b48128 100644 --- a/check/internal/example/buf.gen.yaml +++ b/check/internal/example/buf.gen.yaml @@ -7,7 +7,7 @@ managed: - file_option: go_package_prefix value: buf.build/go/bufplugin/check/internal/example/gen plugins: - - remote: buf.build/protocolbuffers/go + - remote: buf.build/protocolbuffers/go:v1.36.6 out: gen opt: paths=source_relative clean: true