Follow-up from PR #1116 (merged). The engines field was lowered from >=22.19 to >=22.12, and CI gained a packaged-cli-node-22-12 job — but the job only runs --version and help on Node 22.12. That would not catch runtime failures from dist code paths (daemon client stack, YAML parsing, command routing) if they depend on APIs or behavior added after 22.12.
Problem
The tarball is built on the default Node version, then installed and smoke-tested on 22.12 with:
"$prefix/bin/agent-device" --version
"$prefix/bin/agent-device" help
This proves the shebang and minimal entrypoint load, not that real commands execute against the packaged dist/ output on 22.12.
Suggested fix
Extend the 22.12 job with at least one command that imports and executes dist internals, for example:
"$prefix/bin/agent-device" doctor (no device required), or
- a small
--json no-device command that loads the daemon client stack.
Optional: add a matrix leg that runs pnpm build itself on 22.12, or document in the job comment that only packaged-runtime compat is under test.
Acceptance
packaged-cli-node-22-12 CI job exercises at least one non-trivial dist code path on Node 22.12.
- Job failure would have caught a hypothetical
>=22.19-only API usage in shipped dist code.
Context
Follow-up from PR #1116 (merged). The engines field was lowered from
>=22.19to>=22.12, and CI gained apackaged-cli-node-22-12job — but the job only runs--versionandhelpon Node 22.12. That would not catch runtime failures from dist code paths (daemon client stack, YAML parsing, command routing) if they depend on APIs or behavior added after 22.12.Problem
The tarball is built on the default Node version, then installed and smoke-tested on 22.12 with:
This proves the shebang and minimal entrypoint load, not that real commands execute against the packaged
dist/output on 22.12.Suggested fix
Extend the 22.12 job with at least one command that imports and executes dist internals, for example:
"$prefix/bin/agent-device" doctor(no device required), or--jsonno-device command that loads the daemon client stack.Optional: add a matrix leg that runs
pnpm builditself on 22.12, or document in the job comment that only packaged-runtime compat is under test.Acceptance
packaged-cli-node-22-12CI job exercises at least one non-trivial dist code path on Node 22.12.>=22.19-only API usage in shipped dist code.Context
.github/workflows/ci.yml(packaged-cli-node-22-12job)