fix: not releasing the context + linter

Author: paradowstack

packages/host/cpp/RuntimeNodeApiAsync.cpp

@@ -197,16 +197,12 @@ napi_status napi_async_destroy(napi_env env, napi_async_context async_context) {
 }
 
 napi_status napi_make_callback(napi_env env,
-    napi_async_context async_context,
+    napi_async_context,
     napi_value recv,
     napi_value func,
     size_t argc,
     const napi_value* argv,
     napi_value* result) {
-  const auto status = napi_call_function(env, recv, func, argc, argv, result);
-  if (status == napi_pending_exception && async_context) {
-    contexts_.release(async_context);
-  }
-  return status;
+  return napi_call_function(env, recv, func, argc, argv, result);
 }
 }  // namespace callstack::nodeapihost

packages/node-addon-examples/src/index.ts

@@ -15,7 +15,9 @@ function assertLogs(cb: () => void, expectedMessages: string[]) {
     cb();
     if (expectedMessages.length > 0) {
       errors.push(
-        new Error(`Missing expected message(s): ${expectedMessages.join(", ")}`)
+        new Error(
+          `Missing expected message(s): ${expectedMessages.join(", ")}`,
+        ),
       );
     }
   } finally {
@@ -83,6 +85,8 @@ export const suites: Record<
       require("../tests/buffers/addon.js");
     },
     async: () => require("../tests/async/addon.js") as () => Promise<void>,
-    make_callback: () => require("../tests/make_callback/addon.js"),
+    make_callback: () => {
+      require("../tests/make_callback/addon.js");
+    },
   },
 };

packages/node-addon-examples/tests/make_callback/addon.js

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-require-imports */
-/* eslint-disable no-undef */
 const assert = require("assert");
 const binding = require("bindings")("addon.node");
 const makeCallback = binding.makeCallback;
@@ -26,7 +24,7 @@ module.exports = () => {
       assert.strictEqual(this, process);
       return 42;
     }),
-    42
+    42,
   );
 
   assert.strictEqual(
@@ -39,13 +37,13 @@ module.exports = () => {
         assert.strictEqual(x, 1337);
         return 42;
       },
-      1337
+      1337,
     ),
-    42
+    42,
   );
 
   assert.strictEqual(
     makeCallback(resource, process, myMultiArgFunc, 1, 2, 3),
-    42
+    42,
   );
 };