From b15dad71b67f80001bbdc6c05c61ed6286aa6d6f Mon Sep 17 00:00:00 2001 From: Kiril Vatev Date: Sat, 18 Jan 2025 10:52:45 -0500 Subject: [PATCH 1/4] updating support matrix with newer node and electron --- .github/workflows/ci.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 89f72a1..1677d19 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,13 +13,19 @@ jobs: strategy: matrix: os: [macos-latest, windows-latest, ubuntu-latest] - node: [20, 18] - electron: [30, 28, 23] + node: [22, 20] + electron: [34, 32, 30] exclude: # there's an issue with signals in retry-cli on linux in node 20 🤷‍♀️ - os: ubuntu-latest node: 20 include: + - os: windows-latest + electron: 28 + node: 18 + - os: ubuntu-latest + node: 18 + electron: 23 - os: ubuntu-latest node: 16 electron: 20 From 89f15a8d45a2a695d43c16940e4f1ecf23723980 Mon Sep 17 00:00:00 2001 From: Kiril Vatev Date: Sun, 19 Jan 2025 00:59:46 -0500 Subject: [PATCH 2/4] updating to latest retry-cli --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index d8638a6..3cdc0ea 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,7 @@ "fs-extra": "^8.1.0", "mocha": "^6.2.2", "node-stream": "^1.7.0", - "retry-cli": "0.6.0", + "retry-cli": "0.7.0", "symlink-dir": "^3.1.1", "unstyle": "^0.1.0", "xvfb-maybe": "^0.2.1" From f8635fccc51639170dd74765b734b87c08c289d4 Mon Sep 17 00:00:00 2001 From: Kiril Vatev Date: Sun, 19 Jan 2025 01:01:41 -0500 Subject: [PATCH 3/4] Revert "updating to latest retry-cli" This reverts commit 89f15a8d45a2a695d43c16940e4f1ecf23723980. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 3cdc0ea..d8638a6 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,7 @@ "fs-extra": "^8.1.0", "mocha": "^6.2.2", "node-stream": "^1.7.0", - "retry-cli": "0.7.0", + "retry-cli": "0.6.0", "symlink-dir": "^3.1.1", "unstyle": "^0.1.0", "xvfb-maybe": "^0.2.1" From 3600241c8b079ab74c0f522c5597c43b80bb9667 Mon Sep 17 00:00:00 2001 From: Kiril Vatev Date: Sun, 19 Jan 2025 01:16:33 -0500 Subject: [PATCH 4/4] let's try running the tests without retry retry-cli does a weird thing where it passes errors and booleans to `process.exit()` which is no longer allowed in node 22, because it was never the actual API --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index d8638a6..cea1b4b 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,8 @@ "lint": "eslint bin src", "test": "mocha --timeout 20000 --retries=1", "ciinspect": "xvfb-maybe electron --version", - "citest": "xvfb-maybe retry -n 3 -- npm test", + "citest": "xvfb-maybe npm test", + "citest-retry": "xvfb-maybe retry -n 3 -- npm test", "fixture": "cd fixtures && node ../bin/cli.js ." }, "repository": {