ceph-pr-commits: support target branch in docs commit summary#2582
Open
bluikko wants to merge 1 commit into
Open
ceph-pr-commits: support target branch in docs commit summary#2582bluikko wants to merge 1 commit into
bluikko wants to merge 1 commit into
Conversation
ceph/ceph@0a54fcd added a new policy that backport PRs with not-cherry-picked commits need the commit message summary to begin with the target branch name. This policy conflicted with docs-only commits that must have the same line start with "doc", as enforced by this job. Modify the regex used to allow an additional optional "branch: " string in front of the "doc" string in the beginning of the commit message summary, only if "target_branch" is something else than "main". Signed-off-by: Ville Ojamo <git2233+ceph@ojamo.eu>
Contributor
Author
|
Comprehensive testing of this change has not been done. I have only done basic testing in a local Python REPL as I do not know how this could be tested! |
Open
14 tasks
bluikko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ceph/ceph@0a54fcd added a new policy that backport PRs with not-cherry-picked commits need the commit message summary to begin with the target branch name.
This policy conflicted with docs-only commits that must have the same line start with
doc, as enforced by this job.Modify the regex used to allow an additional optional
targetbranch:string in front of thedocstring in the beginning of the commit message summary, only iftarget_branchis something else thanmainand allow only the target branch name.This is a rather naive attempt and the same result could have been done differently so feedback is appreciated.
In essence it allows commit message summary lines such as:
tentacle: doc: fix foo