lint.py: Extracted constants / magic strings into named constants / variables

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>

Author: olehermanse

src/cfengine_cli/lint.py

@@ -40,6 +40,18 @@
 from cfengine_cli.utils import UserError
 
 LINT_EXTENSIONS = (".cf", ".json")
+DEFAULT_NAMESPACE = "default"
+VARS_TYPES = {
+    "data",
+    "ilist",
+    "int",
+    "real",
+    "rlist",
+    "slist",
+    "string",
+}
+PROMISE_BLOCK_ATTRIBUTES = ("path", "interpreter")
+KNOWN_FAULTY_FUNCTION_DEFS = {"regex_replace"}
 
 
 @dataclass
@@ -179,7 +191,7 @@ class State:
     block_name: str | None = None
     promise_type: str | None = None  # "vars" | "files" | "classes" | ... | None
     attribute_name: str | None = None  # "if" | "string" | "slist" | ... | None
-    namespace: str = "default"  # "ns" | "default" | ... |
+    namespace: str = DEFAULT_NAMESPACE  # "ns" | "default" | ... |
     mode: Mode = Mode.NONE
     walking: bool = False
     strict: bool = True
@@ -244,7 +256,7 @@ def start_file(self, policy_file: PolicyFile):
         assert self.mode != Mode.NONE
 
         self.policy_file = policy_file
-        self.namespace = "default"
+        self.namespace = DEFAULT_NAMESPACE
         self.walking = True
 
     def end_file(self) -> None:
@@ -562,24 +574,14 @@ def _lint_node(
         return 1
     if state.promise_type == "vars" and node.type == "promise":
         attribute_nodes = [x for x in node.children if x.type == "attribute"]
-        # Each vars promise must include exactly 1 of these attributes (a value):
-        vars_types = {
-            "data",
-            "ilist",
-            "int",
-            "real",
-            "rlist",
-            "slist",
-            "string",
-        }
         # Attributes are children of a promise, and attribute names are children of attributes
         # Need to iterate inside to find the attribute name (data, ilist, int, etc.)
         value_nodes = []
         for attr in attribute_nodes:
             for child in attr.children:
                 if child.type != "attribute_name":
                     continue
-                if _text(child) in vars_types:
+                if _text(child) in VARS_TYPES:
                     # Ignore the other attributes which are not values
                     value_nodes.append(child)
 
@@ -658,23 +660,17 @@ def _lint_node(
     if (
         state.block_keyword == "promise"
         and node.type == "attribute_name"
-        and state.attribute_name
-        not in (
-            None,
-            "path",
-            "interpreter",
-        )
+        and state.attribute_name not in (None, *PROMISE_BLOCK_ATTRIBUTES)
     ):
         _highlight_range(node, lines)
         print(
             f"Error: Invalid attribute name '{state.attribute_name}' in '{state.block_name}' custom promise type definition {location}"
         )
         return 1
     if node.type == "call":
-        known_faulty_defs = {"regex_replace"}
         call, _, *args, _ = node.children  # f ( a1 , a2 , a..N )
         call = _text(call)
-        if call in known_faulty_defs:
+        if call in KNOWN_FAULTY_FUNCTION_DEFS:
             return 0
 
         args = list(filter(",".__ne__, iter(_text(x) for x in args)))