feat: store and expose validation status

Signed-off-by: Miguel Martinez <miguel@chainloop.dev>

Author: migmartri

app/controlplane/pkg/biz/casbackend.go

@@ -499,16 +499,12 @@ func (uc *CASBackendUseCase) PerformValidation(ctx context.Context, id string) (
 	// 1 - Retrieve the credentials from the external secrets manager
 	var creds any
 	if err := uc.credsRW.ReadCredentials(ctx, backend.SecretName, &creds); err != nil {
-		errMsg := fmt.Sprintf("credentials not found or invalid: %v", err)
-		validationError = &errMsg
 		uc.logger.Infow("msg", "credentials not found or invalid", "ID", id, "error", err)
 		return nil
 	}
 
 	credsJSON, err := json.Marshal(creds)
 	if err != nil {
-		errMsg := fmt.Sprintf("credentials invalid: %v", err)
-		validationError = &errMsg
 		uc.logger.Infow("msg", "credentials invalid", "ID", id, "error", err)
 		return nil
 	}

app/controlplane/pkg/biz/casbackend_test.go

@@ -140,7 +140,7 @@ func (s *casBackendTestSuite) TestPerformValidation() {
 
 	t.Run("proper provider credentials missing, set validation status => invalid", func(_ *testing.T) {
 		s.repo.On("FindByID", mock.Anything, s.validUUID).Return(validRepo, nil)
-		s.repo.On("UpdateValidationStatus", mock.Anything, s.validUUID, biz.CASBackendValidationFailed).Return(nil)
+		s.repo.On("UpdateValidationStatus", mock.Anything, s.validUUID, biz.CASBackendValidationFailed, mock.Anything).Return(nil)
 
 		s.credsRW.On("ReadCredentials", mock.Anything, mock.Anything, mock.Anything).Return(credentials.ErrNotFound)
 		err := s.useCase.PerformValidation(context.Background(), s.validUUID.String())
@@ -150,7 +150,7 @@ func (s *casBackendTestSuite) TestPerformValidation() {
 
 	t.Run("invalid credentials, set validation status => invalid", func(_ *testing.T) {
 		s.repo.On("FindByID", mock.Anything, s.validUUID).Return(validRepo, nil)
-		s.repo.On("UpdateValidationStatus", mock.Anything, s.validUUID, biz.CASBackendValidationFailed).Return(nil)
+		s.repo.On("UpdateValidationStatus", mock.Anything, s.validUUID, biz.CASBackendValidationFailed, mock.Anything).Return(nil)
 		s.credsRW.On("ReadCredentials", mock.Anything, mock.Anything, mock.Anything).Return(nil)
 		s.backendProvider.On("ValidateAndExtractCredentials", validRepo.Location, mock.Anything).Return(nil, errors.New("invalid credentials"))
 
@@ -161,7 +161,7 @@ func (s *casBackendTestSuite) TestPerformValidation() {
 
 	t.Run("valid credentials, set validation status => ok", func(_ *testing.T) {
 		s.repo.On("FindByID", mock.Anything, s.validUUID).Return(validRepo, nil)
-		s.repo.On("UpdateValidationStatus", mock.Anything, s.validUUID, biz.CASBackendValidationOK).Return(nil)
+		s.repo.On("UpdateValidationStatus", mock.Anything, s.validUUID, biz.CASBackendValidationOK, mock.Anything).Return(nil)
 		s.credsRW.On("ReadCredentials", mock.Anything, mock.Anything, mock.Anything).Return(nil)
 		s.backendProvider.On("ValidateAndExtractCredentials", validRepo.Location, mock.Anything).Return(nil, nil)
 

app/controlplane/pkg/data/casbackend.go

@@ -257,7 +257,7 @@ func entCASBackendToBiz(backend *ent.CASBackend) *biz.CASBackend {
 		CreatedAt:        toTimePtr(backend.CreatedAt),
 		ValidatedAt:      toTimePtr(backend.ValidatedAt),
 		ValidationStatus: backend.ValidationStatus,
-		ValidationError:  biz.ToPtr(backend.ValidationError),
+		ValidationError:  toStringPtr(backend.ValidationError),
 		Provider:         backend.Provider,
 		Default:          backend.Default,
 		Inline:           backend.Provider == biz.CASBackendInline,

app/controlplane/pkg/data/data.go

@@ -143,6 +143,13 @@ func toTimePtr(t time.Time) *time.Time {
 	return &t
 }
 
+func toStringPtr(s string) *string {
+	if s == "" {
+		return nil
+	}
+	return &s
+}
+
 func orgScopedQuery(client *ent.Client, orgID uuid.UUID) *ent.OrganizationQuery {
 	return client.Organization.Query().Where(organization.ID(orgID), organization.DeletedAtIsNil())
 }