feat(cas-backends): When updating CAS Backends events are sent

Signed-off-by: Javier Rodriguez <javier@chainloop.dev>

Author: javirln

app/controlplane/pkg/auditor/events/casbackend.go

@@ -47,7 +47,7 @@ type CASBackendBase struct {
 	CASBackendName string     `json:"cas_backend_name,omitempty"`
 	Provider       string     `json:"provider,omitempty"`
 	Location       string     `json:"location,omitempty"`
-	Default        bool       `json:"default,omitempty"`
+	Default        bool       `json:"default"`
 }
 
 func (c *CASBackendBase) RequiresActor() bool {
@@ -100,8 +100,8 @@ func (c *CASBackendCreated) Description() string {
 type CASBackendUpdated struct {
 	*CASBackendBase
 	NewDescription     *string `json:"new_description,omitempty"`
-	CredentialsChanged bool    `json:"credentials_changed,omitempty"`
-	PreviousDefault    bool    `json:"previous_default,omitempty"`
+	CredentialsChanged bool    `json:"credentials_changed"`
+	PreviousDefault    bool    `json:"previous_default"`
 }
 
 func (c *CASBackendUpdated) ActionType() string {
@@ -184,7 +184,7 @@ type CASBackendStatusChanged struct {
 	PreviousStatus string `json:"previous_status,omitempty"`
 	NewStatus      string `json:"new_status,omitempty"`
 	StatusError    string `json:"status_error,omitempty"`
-	IsRecovery     bool   `json:"is_recovery,omitempty"`
+	IsRecovery     bool   `json:"is_recovery"`
 }
 
 func (c *CASBackendStatusChanged) ActionType() string {

app/controlplane/pkg/biz/casbackend.go

@@ -336,26 +336,56 @@ func (uc *CASBackendUseCase) Update(ctx context.Context, orgID, id, description
 	}
 
 	var secretName string
+	credentialsUpdated := false
 	// We want to rotate credentials
 	if creds != nil {
 		secretName, err = uc.credsRW.SaveCredentials(ctx, orgID, creds)
 		if err != nil {
 			return nil, fmt.Errorf("storing the credentials: %w", err)
 		}
+		credentialsUpdated = true
 	}
 
-	after, err := uc.repo.Update(ctx, &CASBackendUpdateOpts{
+	// Update the backend without modifying validation status directly
+	// The validation status will be updated through PerformValidation if needed
+	// Don't set validation status here - let PerformValidation handle it
+	updateOpts := &CASBackendUpdateOpts{
 		ID: uuid,
 		CASBackendOpts: &CASBackendOpts{
-			SecretName: secretName, Default: defaultB, Description: description, OrgID: orgUUID,
-			ValidationStatus: CASBackendValidationOK,
-			ValidationError:  ToPtr(""),
+			SecretName:  secretName,
+			Default:     defaultB,
+			Description: description,
+			OrgID:       orgUUID,
 		},
-	})
+	}
+
+	// If we're not updating credentials, preserve the current validation status
+	if !credentialsUpdated {
+		updateOpts.CASBackendOpts.ValidationStatus = before.ValidationStatus
+		updateOpts.CASBackendOpts.ValidationError = before.ValidationError
+	}
+
+	after, err := uc.repo.Update(ctx, updateOpts)
 	if err != nil {
 		return nil, err
 	}
 
+	// If credentials were updated, perform validation to check if they work
+	// This will properly update validation status and send events
+	if credentialsUpdated {
+		if err := uc.PerformValidation(ctx, id); err != nil {
+			// Log the validation error but don't fail the update operation
+			// The validation status will be updated by PerformValidation
+			uc.logger.Warnw("msg", "validation failed after credential update", "ID", id, "error", err)
+		}
+
+		// Reload the backend to get the updated validation status
+		after, err = uc.repo.FindByIDInOrg(ctx, orgUUID, uuid)
+		if err != nil {
+			return nil, fmt.Errorf("reloading backend after validation: %w", err)
+		}
+	}
+
 	// If we just updated the backend from default=true => default=false, we need to set up the fallback as default
 	if before.Default && !after.Default {
 		if _, err := uc.defaultFallbackBackend(ctx, orgID); err != nil {
@@ -374,7 +404,7 @@ func (uc *CASBackendUseCase) Update(ctx context.Context, orgID, id, description
 				Default:        after.Default,
 			},
 			NewDescription:     &description,
-			CredentialsChanged: creds != nil,
+			CredentialsChanged: credentialsUpdated,
 			PreviousDefault:    before.Default,
 		}, &orgUUID)
 	}