add tests

Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>

Author: Piskoo

app/cli/pkg/action/attestation_init.go

@@ -238,8 +238,8 @@ func (action *AttestationInit) Run(ctx context.Context, opts *AttestationInitRun
 	initOpts := &crafter.InitOpts{
 		WfInfo: workflowMeta,
 		//nolint:staticcheck // TODO: Migrate to new contract version API
-		SchemaV1: contractVersion.GetV1(),
-		SchemaV2: schemaV2,
+		SchemaV1:                 contractVersion.GetV1(),
+		SchemaV2:                 schemaV2,
 		DryRun:                   action.dryRun,
 		AttestationID:            attestationID,
 		Runner:                   discoveredRunner,
@@ -374,7 +374,7 @@ func parseContractV2(rawContract *pb.WorkflowContractVersionItem_RawBody) *v1.Cr
 	if rawContract == nil {
 		return nil
 	}
-	
+
 	rawFormat := func() unmarshal.RawFormat {
 		switch rawContract.GetFormat() {
 		case pb.WorkflowContractVersionItem_RawBody_FORMAT_JSON:
@@ -387,12 +387,12 @@ func parseContractV2(rawContract *pb.WorkflowContractVersionItem_RawBody) *v1.Cr
 			return unmarshal.RawFormatYAML
 		}
 	}()
-	
+
 	schemaV2 := &v1.CraftingSchemaV2{}
 	if err := unmarshal.FromRaw(rawContract.GetBody(), rawFormat, schemaV2, true); err != nil {
 		// If V2 parsing fails, return nil
 		return nil
 	}
-	
+
 	return schemaV2
 }

app/cli/pkg/action/attestation_init_test.go

@@ -17,9 +17,11 @@ package action
 
 import (
 	"context"
+	"os"
 	"slices"
 	"testing"
 
+	pb "github.com/chainloop-dev/chainloop/app/controlplane/api/controlplane/v1"
 	v1 "github.com/chainloop-dev/chainloop/app/controlplane/api/workflowcontract/v1"
 	"github.com/rs/zerolog"
 	"github.com/stretchr/testify/assert"
@@ -175,3 +177,87 @@ func TestTemplatedGroups(t *testing.T) {
 		})
 	}
 }
+
+func TestParseContractV2(t *testing.T) {
+	testCases := []struct {
+		name           string
+		contractFile   string
+		format         pb.WorkflowContractVersionItem_RawBody_Format
+		expectV2Schema bool
+		expectName     string
+		expectError    bool
+	}{
+		{
+			name:           "valid V2 YAML contract",
+			contractFile:   "testdata/contract_v2.yaml",
+			format:         pb.WorkflowContractVersionItem_RawBody_FORMAT_YAML,
+			expectV2Schema: true,
+			expectName:     "test-contract-v2",
+		},
+		{
+			name:           "V1 contract should fail V2 parsing",
+			contractFile:   "testdata/contract_v1.yaml",
+			format:         pb.WorkflowContractVersionItem_RawBody_FORMAT_YAML,
+			expectV2Schema: false,
+		},
+		{
+			name:           "invalid contract data",
+			contractFile:   "testdata/invalid_contract.yaml",
+			format:         pb.WorkflowContractVersionItem_RawBody_FORMAT_YAML,
+			expectV2Schema: false,
+		},
+		{
+			name:           "nil raw contract",
+			contractFile:   "",
+			format:         pb.WorkflowContractVersionItem_RawBody_FORMAT_YAML,
+			expectV2Schema: false,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			var rawContract *pb.WorkflowContractVersionItem_RawBody
+
+			if tc.contractFile != "" {
+				// Load contract file
+				data, err := os.ReadFile(tc.contractFile)
+				if err != nil {
+					if tc.expectV2Schema {
+						require.NoError(t, err, "Failed to load contract file")
+					}
+					// For non-existent files, test with nil
+					rawContract = nil
+				} else {
+					rawContract = &pb.WorkflowContractVersionItem_RawBody{
+						Body:   data,
+						Format: tc.format,
+					}
+				}
+			}
+
+			result := parseContractV2(rawContract)
+
+			if tc.expectV2Schema {
+				require.NotNil(t, result, "Expected V2 schema to be parsed successfully")
+				assert.Equal(t, "chainloop.dev/v1", result.GetApiVersion())
+				assert.Equal(t, "Contract", result.GetKind())
+				if tc.expectName != "" {
+					assert.Equal(t, tc.expectName, result.GetMetadata().GetName())
+				}
+
+				// Verify spec fields exist
+				spec := result.GetSpec()
+				require.NotNil(t, spec, "Spec should not be nil")
+				assert.Greater(t, len(spec.GetMaterials()), 0, "Should have materials")
+				assert.Greater(t, len(spec.GetEnvAllowList()), 0, "Should have env allow list")
+				assert.NotNil(t, spec.GetRunner(), "Should have runner config")
+
+				// Verify annotations in metadata
+				annotations := result.GetMetadata().GetAnnotations()
+				assert.NotEmpty(t, annotations, "Should have metadata annotations")
+			} else {
+				assert.Nil(t, result, "Expected V2 schema parsing to fail")
+			}
+		})
+	}
+}

pkg/attestation/crafter/api/attestation/v1/crafting_state_validations.go

@@ -86,14 +86,6 @@ func (state *CraftingState) GetMaterials() []*workflowcontract.CraftingSchema_Ma
 	}
 }
 
-// GetV1Schema returns the v1 schema if available, nil otherwise
-func (state *CraftingState) GetV1Schema() *workflowcontract.CraftingSchema {
-	if schema, ok := state.GetSchema().(*CraftingState_InputSchema); ok {
-		return schema.InputSchema
-	}
-	return nil
-}
-
 // GetAnnotations returns the annotations from either v1 or v2 schema
 func (state *CraftingState) GetAnnotations() []*workflowcontract.Annotation {
 	switch schema := state.GetSchema().(type) {