fix: translate empty version in ProjectVersionUseCase.Create and fix workflow test

migmartri · migmartri · commit 5bb5a0744090 · 2026-04-16T18:08:34.000+02:00
Add backward-compat "" → "v0" translation in ProjectVersionUseCase.Create
to match WorkflowRunUseCase.Create behavior. Update workflow integration
test to look up the default version by DefaultVersionName instead of "".

Signed-off-by: Miguel Martinez Trivino &lt;miguel@chainloop.dev&gt;
diff --git a/app/controlplane/pkg/biz/projectversion.go b/app/controlplane/pkg/biz/projectversion.go
@@ -94,6 +94,11 @@ func (uc *ProjectVersionUseCase) Create(ctx context.Context, projectID, version
 		return nil, NewErrInvalidUUID(err)
 	}
 
+	// Treat empty version as the default for backward compatibility
+	if version == "" {
+		version = DefaultVersionName
+	}
+
 	if err := ValidateVersion(version); err != nil {
 		return nil, err
 	}
diff --git a/app/controlplane/pkg/biz/workflow_integration_test.go b/app/controlplane/pkg/biz/workflow_integration_test.go
@@ -210,7 +210,7 @@ func (s *workflowIntegrationTestSuite) TestCreate() {
 			s.NotEmpty(got.ContractID)
 			s.NotEmpty(got.ContractName)
 			// There is a project version created
-			pv, err := s.ProjectVersion.FindByProjectAndVersion(ctx, got.ProjectID.String(), "")
+			pv, err := s.ProjectVersion.FindByProjectAndVersion(ctx, got.ProjectID.String(), biz.DefaultVersionName)
 			s.NoError(err)
 			s.NotNil(pv)
 		})

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,11 @@ func (uc *ProjectVersionUseCase) Create(ctx context.Context, projectID, version`
`94`	`94`	`return nil, NewErrInvalidUUID(err)`
`95`	`95`	`}`
`96`	`96`
	`97`	`+ // Treat empty version as the default for backward compatibility`
	`98`	`+ if version == "" {`
	`99`	`+ version = DefaultVersionName`
	`100`	`+ }`
	`101`	`+`
`97`	`102`	`if err := ValidateVersion(version); err != nil {`
`98`	`103`	`return nil, err`
`99`	`104`	`}`