add-material-kind-policy-validation

Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>

Author: Piskoo

app/controlplane/pkg/biz/workflowcontract.go

@@ -394,9 +394,16 @@ func (uc *WorkflowContractUseCase) ValidateContractPolicies(rawSchema []byte, to
 		}
 	}
 	for _, att := range c.Schema.GetPolicies().GetMaterials() {
-		if _, err := uc.findAndValidatePolicy(att, token); err != nil {
+		policy, err := uc.findAndValidatePolicy(att, token)
+		if err != nil {
 			return NewErrValidation(err)
 		}
+		// Validate that policies attached to materials do not have kind ATTESTATION
+		if policy != nil {
+			if err := validatePolicyIsNotAttestationKind(policy); err != nil {
+				return NewErrValidation(err)
+			}
+		}
 	}
 	for _, gatt := range c.Schema.GetPolicyGroups() {
 		if _, err := uc.findPolicyGroup(gatt, token); err != nil {
@@ -640,6 +647,25 @@ func SchemaToRawContract(contract *schemav1.CraftingSchema) (*Contract, error) {
 	return &Contract{Raw: r, Format: unmarshal.RawFormatJSON, Schema: contract}, nil
 }
 
+// validatePolicyIsNotAttestationKind validates that a policy does not have kind ATTESTATION.
+// Policies with kind ATTESTATION should only be attached at the attestation level, not to individual materials.
+func validatePolicyIsNotAttestationKind(policy *schemav1.Policy) error {
+	policies := policy.GetSpec().GetPolicies()
+	if len(policies) == 0 {
+		// Legacy format or no policies defined
+		return nil
+	}
+
+	// Check if any policy has kind ATTESTATION - this is not allowed for material-level policies
+	for _, policySpec := range policies {
+		if policySpec.GetKind() == schemav1.CraftingSchema_Material_ATTESTATION {
+			return fmt.Errorf("attestation policy %q cannot be attached to materials", policy.GetMetadata().GetName())
+		}
+	}
+
+	return nil
+}
+
 // ContractScope represents a polymorphic relationship between a contract and a project or organization
 type ContractScope string
 

app/controlplane/pkg/biz/workflowcontract_test.go

@@ -1,5 +1,5 @@
 //
-// Copyright 2024 The Chainloop Authors.
+// Copyright 2024-2025 The Chainloop Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -19,6 +19,7 @@ import (
 	"os"
 	"testing"
 
+	schemav1 "github.com/chainloop-dev/chainloop/app/controlplane/api/workflowcontract/v1"
 	"github.com/chainloop-dev/chainloop/app/controlplane/pkg/unmarshal"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -81,3 +82,104 @@ func TestIdentifyAndValidateRawContract(t *testing.T) {
 		})
 	}
 }
+
+func TestValidatePolicyIsNotAttestationKind(t *testing.T) {
+	testCases := []struct {
+		name      string
+		policy    *schemav1.Policy
+		wantError bool
+		errMsg    string
+	}{
+		{
+			name: "valid material-level policy with kind SBOM_SPDX_JSON",
+			policy: &schemav1.Policy{
+				Metadata: &schemav1.Metadata{
+					Name: "sbom-validation",
+				},
+				Spec: &schemav1.PolicySpec{
+					Policies: []*schemav1.PolicySpecV2{
+						{
+							Kind: schemav1.CraftingSchema_Material_SBOM_SPDX_JSON,
+							Source: &schemav1.PolicySpecV2_Embedded{
+								Embedded: "package main\nresult := true",
+							},
+						},
+					},
+				},
+			},
+			wantError: false,
+		},
+		{
+			name: "invalid policy with kind ATTESTATION in materials section",
+			policy: &schemav1.Policy{
+				Metadata: &schemav1.Metadata{
+					Name: "attestation-policy",
+				},
+				Spec: &schemav1.PolicySpec{
+					Policies: []*schemav1.PolicySpecV2{
+						{
+							Kind: schemav1.CraftingSchema_Material_ATTESTATION,
+							Source: &schemav1.PolicySpecV2_Embedded{
+								Embedded: "package main\nresult := true",
+							},
+						},
+					},
+				},
+			},
+			wantError: true,
+			errMsg:    "cannot be attached to materials",
+		},
+		{
+			name: "invalid policy with multiple kinds including ATTESTATION",
+			policy: &schemav1.Policy{
+				Metadata: &schemav1.Metadata{
+					Name: "multi-kind-policy",
+				},
+				Spec: &schemav1.PolicySpec{
+					Policies: []*schemav1.PolicySpecV2{
+						{
+							Kind: schemav1.CraftingSchema_Material_SBOM_SPDX_JSON,
+							Source: &schemav1.PolicySpecV2_Embedded{
+								Embedded: "package main\nresult := true",
+							},
+						},
+						{
+							Kind: schemav1.CraftingSchema_Material_ATTESTATION,
+							Source: &schemav1.PolicySpecV2_Embedded{
+								Embedded: "package main\nresult := true",
+							},
+						},
+					},
+				},
+			},
+			wantError: true,
+			errMsg:    "cannot be attached to materials",
+		},
+		{
+			name: "legacy policy with deprecated path field - should pass",
+			policy: &schemav1.Policy{
+				Metadata: &schemav1.Metadata{
+					Name: "legacy-path-policy",
+				},
+				Spec: &schemav1.PolicySpec{
+					Source: &schemav1.PolicySpec_Path{
+						Path: "file://policy.rego",
+					},
+				},
+			},
+			wantError: false,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			err := validatePolicyIsNotAttestationKind(tc.policy)
+			if tc.wantError {
+				require.Error(t, err)
+				assert.Contains(t, err.Error(), tc.errMsg)
+			} else {
+				require.NoError(t, err)
+			}
+		})
+	}
+}