chore(db): improve find workflow by name (#1564)

Signed-off-by: Miguel Martinez <miguel@chainloop.dev>

Author: migmartri

app/controlplane/pkg/data/workflow.go

@@ -259,7 +259,6 @@ func (r *WorkflowRepo) GetOrgScoped(ctx context.Context, orgID, workflowID uuid.
 		QueryWorkflows().
 		Where(workflow.ID(workflowID), workflow.DeletedAtIsNil()).
 		WithContract().WithOrganization().WithLatestWorkflowRun().
-		Order(ent.Desc(workflow.FieldCreatedAt)).
 		Only(ctx)
 
 	if err != nil {
@@ -274,12 +273,16 @@ func (r *WorkflowRepo) GetOrgScoped(ctx context.Context, orgID, workflowID uuid.
 
 // GetOrgScopedByProjectAndName Gets a workflow by name making sure it belongs to a given org
 func (r *WorkflowRepo) GetOrgScopedByProjectAndName(ctx context.Context, orgID uuid.UUID, projectName, workflowName string) (*biz.Workflow, error) {
-	wf, err := orgScopedQuery(r.data.DB, orgID).QueryWorkflows().
-		Where(workflow.HasProjectWith(project.Name(projectName)), workflow.Name(workflowName), workflow.DeletedAtIsNil()).
-		WithContract().WithOrganization().WithProject().WithLatestWorkflowRun().
-		Order(ent.Desc(workflow.FieldCreatedAt)).
-		Only(ctx)
+	p, err := r.data.DB.Project.Query().Where(project.Name(projectName), project.OrganizationIDEQ(orgID), project.DeletedAtIsNil()).First(ctx)
+	if err != nil {
+		if ent.IsNotFound(err) {
+			return nil, biz.NewErrNotFound("project")
+		}
+		return nil, err
+	}
 
+	wf, err := r.data.DB.Workflow.Query().Where(workflow.ProjectIDEQ(p.ID), workflow.Name(workflowName), workflow.DeletedAtIsNil()).
+		WithContract().WithOrganization().WithProject().WithLatestWorkflowRun().First(ctx)
 	if err != nil {
 		if ent.IsNotFound(err) {
 			return nil, biz.NewErrNotFound("workflow")

app/controlplane/pkg/data/workflowrun.go

@@ -56,7 +56,7 @@ func (r *WorkflowRunRepo) Create(ctx context.Context, opts *biz.WorkflowRunRepoC
 
 	// load the version in advance to prevent locking if it already exists
 	versionID, err := r.data.DB.ProjectVersion.Query().
-		Where(projectversion.Version(opts.ProjectVersion), projectversion.ProjectID(wf.ProjectID), projectversion.DeletedAtIsNil()).OnlyID(ctx)
+		Where(projectversion.Version(opts.ProjectVersion), projectversion.ProjectID(wf.ProjectID), projectversion.DeletedAtIsNil()).FirstID(ctx)
 	if err != nil && !ent.IsNotFound(err) {
 		return nil, fmt.Errorf("checking existing version: %w", err)
 	}