refactor(cli): remove unreachable policy-violation fallback handling

Signed-off-by: Matías Insaurralde <matias@chainloop.dev>

Author: matiasinsaurralde

app/cli/cmd/attestation_push.go

@@ -163,8 +163,7 @@ func newAttestationPushCmd() *cobra.Command {
 const exceptionFlagName = "exception-bypass-policy-check"
 
 var (
-	ErrBlockedByPolicyViolation = fmt.Errorf("the operator requires all policies to pass before continuing, please fix them and try again or temporarily bypass the policy check using --%s", exceptionFlagName)
-	exceptionBypassPolicyCheck  = fmt.Sprintf("Attention: You have opted to bypass the policy enforcement check and an operator has been notified of this exception.\nPlease make sure you are back on track with the policy evaluations and remove the --%s as soon as possible.", exceptionFlagName)
+	exceptionBypassPolicyCheck = fmt.Sprintf("Attention: You have opted to bypass the policy enforcement check and an operator has been notified of this exception.\nPlease make sure you are back on track with the policy evaluations and remove the --%s as soon as possible.", exceptionFlagName)
 )
 
 type GateError struct {
@@ -202,12 +201,6 @@ func validatePolicyEnforcement(status *action.AttestationStatusResult, bypassPol
 			return nil
 		}
 
-		// Effective gate semantics are already resolved in policy evaluations.
-		// For backwards compatibility, fall back to aggregate status only if
-		// no evaluations are available.
-		if len(status.PolicyEvaluations) == 0 && status.HasPolicyViolations {
-			return ErrBlockedByPolicyViolation
-		}
 	}
 
 	return nil

app/cli/main.go

@@ -1,5 +1,5 @@
 //
-// Copyright 2023-2025 The Chainloop Authors.
+// Copyright 2023-2026 The Chainloop Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -100,9 +100,6 @@ func errorInfo(err error, logger zerolog.Logger) (string, int) {
 			logger.Debug().Msg("GracefulErrorExit enabled (exitCode 0). If you want to disable it set --graceful-exit=false")
 			exitCode = 0
 		}
-	case errors.Is(err, cmd.ErrBlockedByPolicyViolation):
-		// default exit code for policy violations
-		exitCode = 3
 	case errors.As(err, &gateErr):
 		// exit code for gate errors
 		exitCode = 4