fix exit codes

Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>

Author: Piskoo

app/cli/cmd/policy_develop_lint.go

@@ -49,19 +49,18 @@ func newPolicyDevelopLintCmd() *cobra.Command {
 				RegalConfig: regalConfig,
 			})
 			if err != nil {
-				fmt.Errorf("linting failed: %w", err)
-				os.Exit(1)
-				return nil
+				return fmt.Errorf("linting policy: %w", err)
 			}
 
 			if result.Valid {
 				logger.Info().Msg("policy is valid!")
 				return nil
 			}
 
-			encodeOutput(result, policyLintTable)
-			os.Exit(1)
-			return nil
+			if err := encodeOutput(result, policyLintTable); err != nil {
+				return fmt.Errorf("failed to encode output: %w", err)
+			}
+			return fmt.Errorf("%d issues found", len(result.Errors))
 		},
 	}
 
@@ -75,7 +74,7 @@ func newPolicyDevelopLintCmd() *cobra.Command {
 func policyLintTable(result *action.PolicyLintResult) error {
 	tw := table.NewWriter()
 	tw.SetOutputMirror(os.Stdout)
-	tw.AppendHeader(table.Row{"#", "Error"})
+	tw.AppendHeader(table.Row{"#", "Issue"})
 
 	for i, err := range result.Errors {
 		tw.AppendRow(table.Row{i + 1, err})

app/cli/internal/policydevel/lint.go

@@ -369,7 +369,7 @@ func (p *PolicyToLint) processRegalViolation(rawErr error, path string) {
 
 	// Replace "opa fmt" with "--format" in error messages
 	errorStr = strings.ReplaceAll(errorStr, "`opa fmt`", "`--format`")
-	//Regex matches file path, line number and error message like: /path/file:line: message
+	// Regex matches file path, line number and error message like: /path/file:line: message
 	re := regexp.MustCompile(`^(.*\.rego):(\d+):\s*(.+)$`)
 
 	// Handle the special case: "1 error occurred:"