From ca84ddf458af8c7a59aa0ec9f34cf241d7d0736f Mon Sep 17 00:00:00 2001 From: Sylwester Piskozub Date: Fri, 13 Feb 2026 00:24:25 +0100 Subject: [PATCH 1/2] expose output functions Signed-off-by: Sylwester Piskozub --- app/cli/cmd/attached_integration_add.go | 2 +- app/cli/cmd/registered_integration_add.go | 12 ++++++------ app/cli/cmd/registered_integration_list.go | 8 ++++---- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/app/cli/cmd/attached_integration_add.go b/app/cli/cmd/attached_integration_add.go index 394587bf6..e887e6029 100644 --- a/app/cli/cmd/attached_integration_add.go +++ b/app/cli/cmd/attached_integration_add.go @@ -48,7 +48,7 @@ func newAttachedIntegrationAttachCmd() *cobra.Command { } // Parse and validate options - opts, err := parseAndValidateOpts(options, item.Attachment) + opts, err := ParseAndValidateOpts(options, item.Attachment) if err != nil { // Show schema table if validation fails if err := RenderSchemaTable("Available options", item.Attachment.Properties); err != nil { diff --git a/app/cli/cmd/registered_integration_add.go b/app/cli/cmd/registered_integration_add.go index ef1d85200..da0b428dc 100644 --- a/app/cli/cmd/registered_integration_add.go +++ b/app/cli/cmd/registered_integration_add.go @@ -49,7 +49,7 @@ func newRegisteredIntegrationAddCmd() *cobra.Command { } // Parse and validate options - opts, err := parseAndValidateOpts(options, item.Registration) + opts, err := ParseAndValidateOpts(options, item.Registration) if err != nil { // Show schema table if validation fails if err := RenderSchemaTable("Available options", item.Registration.Properties); err != nil { @@ -63,7 +63,7 @@ func newRegisteredIntegrationAddCmd() *cobra.Command { return err } - return output.EncodeOutput(flagOutputFormat, res, registeredIntegrationItemTableOutput) + return output.EncodeOutput(flagOutputFormat, res, RegisteredIntegrationItemTableOutput) }, } @@ -79,9 +79,9 @@ func newRegisteredIntegrationAddCmd() *cobra.Command { return cmd } -func parseAndValidateOpts(opts []string, schema *action.JSONSchema) (map[string]any, error) { +func ParseAndValidateOpts(opts []string, schema *action.JSONSchema) (map[string]any, error) { // Parse - res, err := parseKeyValOpts(opts, schema.Properties) + res, err := ParseKeyValOpts(opts, schema.Properties) if err != nil { return nil, fmt.Errorf("failed to parse options: %w", err) } @@ -101,10 +101,10 @@ func parseAndValidateOpts(opts []string, schema *action.JSONSchema) (map[string] return res, nil } -// parseKeyValOpts performs two steps +// ParseKeyValOpts performs two steps // 1 - Split the options into key/value pairs // 2 - Cast the values to the expected type defined in the schema -func parseKeyValOpts(opts []string, propertiesMap sdk.SchemaPropertiesMap) (map[string]any, error) { +func ParseKeyValOpts(opts []string, propertiesMap sdk.SchemaPropertiesMap) (map[string]any, error) { // 1 - Split the options into key/value pairs var options = make(map[string]any) for _, opt := range opts { diff --git a/app/cli/cmd/registered_integration_list.go b/app/cli/cmd/registered_integration_list.go index 7f2e69c40..b05edb838 100644 --- a/app/cli/cmd/registered_integration_list.go +++ b/app/cli/cmd/registered_integration_list.go @@ -37,18 +37,18 @@ func newRegisteredIntegrationListCmd() *cobra.Command { return err } - return output.EncodeOutput(flagOutputFormat, res, registeredIntegrationListTableOutput) + return output.EncodeOutput(flagOutputFormat, res, RegisteredIntegrationListTableOutput) }, } return cmd } -func registeredIntegrationItemTableOutput(item *action.RegisteredIntegrationItem) error { - return registeredIntegrationListTableOutput([]*action.RegisteredIntegrationItem{item}) +func RegisteredIntegrationItemTableOutput(item *action.RegisteredIntegrationItem) error { + return RegisteredIntegrationListTableOutput([]*action.RegisteredIntegrationItem{item}) } -func registeredIntegrationListTableOutput(items []*action.RegisteredIntegrationItem) error { +func RegisteredIntegrationListTableOutput(items []*action.RegisteredIntegrationItem) error { switch n := len(items); { case n == 0: fmt.Println("there are no third party integrations configured in your organization yet") From 49e6d81c1aada15f7482c0b3984ed9c939235473 Mon Sep 17 00:00:00 2001 From: Sylwester Piskozub Date: Fri, 13 Feb 2026 10:41:39 +0100 Subject: [PATCH 2/2] remove table output Signed-off-by: Sylwester Piskozub --- app/cli/cmd/registered_integration_add.go | 2 +- app/cli/cmd/registered_integration_list.go | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/cli/cmd/registered_integration_add.go b/app/cli/cmd/registered_integration_add.go index da0b428dc..eff0341f2 100644 --- a/app/cli/cmd/registered_integration_add.go +++ b/app/cli/cmd/registered_integration_add.go @@ -63,7 +63,7 @@ func newRegisteredIntegrationAddCmd() *cobra.Command { return err } - return output.EncodeOutput(flagOutputFormat, res, RegisteredIntegrationItemTableOutput) + return output.EncodeOutput(flagOutputFormat, res, registeredIntegrationItemTableOutput) }, } diff --git a/app/cli/cmd/registered_integration_list.go b/app/cli/cmd/registered_integration_list.go index b05edb838..7f2e69c40 100644 --- a/app/cli/cmd/registered_integration_list.go +++ b/app/cli/cmd/registered_integration_list.go @@ -37,18 +37,18 @@ func newRegisteredIntegrationListCmd() *cobra.Command { return err } - return output.EncodeOutput(flagOutputFormat, res, RegisteredIntegrationListTableOutput) + return output.EncodeOutput(flagOutputFormat, res, registeredIntegrationListTableOutput) }, } return cmd } -func RegisteredIntegrationItemTableOutput(item *action.RegisteredIntegrationItem) error { - return RegisteredIntegrationListTableOutput([]*action.RegisteredIntegrationItem{item}) +func registeredIntegrationItemTableOutput(item *action.RegisteredIntegrationItem) error { + return registeredIntegrationListTableOutput([]*action.RegisteredIntegrationItem{item}) } -func RegisteredIntegrationListTableOutput(items []*action.RegisteredIntegrationItem) error { +func registeredIntegrationListTableOutput(items []*action.RegisteredIntegrationItem) error { switch n := len(items); { case n == 0: fmt.Println("there are no third party integrations configured in your organization yet")