virtio: build failure on 7.0

[tobhe]

With the Ubuntu default config I get:

/<<PKGBUILDDIR>>/drivers/firmware/arm_scmi/transports/virtio.c:783:27: error: initialization of ‘bool (*)(struct fwnode_handle *, int)’ {aka ‘_Bool (*)(struct fwnode_handle *, int)’} from incompatible pointer type ‘bool (*)(struct device_node *, int)’ {aka ‘_Bool (*)(struct device_node *, int)’} [-Wincompatible-pointer-types]
  783 |         .chan_available = virtio_chan_available,
      |                           ^~~~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/drivers/firmware/arm_scmi/transports/virtio.c:783:27: note: (near initialization for ‘scmi_virtio_ops.chan_available’)
/<<PKGBUILDDIR>>/drivers/firmware/arm_scmi/transports/virtio.c:376:13: note: ‘virtio_chan_available’ declared here
  376 | static bool virtio_chan_available(struct device_node *of_node, int idx)
      |             ^~~~~~~~~~~~~~~~~~~~~

[amazingfate]

Hello, would you prodive your full kernel config?

[tobhe]

sure, here is the config I used: config-7.0.0-15-cix.txt

This is caused by:

commit c981a70440e6fff77636dc62d10b4049dec94b1e
Author: Jianfeng Liu <Jianfeng.Liu@cixtech.com>
Date:   Wed Mar 18 14:29:38 2026 +0800

    firmware: arm_scmi: add acpi support to SCMI
    
    Signed-off-by: Jianfeng Liu <Jianfeng.Liu@cixtech.com>

The fix should be trivial. of_node isn't actually ever used:

diff --git a/drivers/firmware/arm_scmi/transports/virtio.c b/drivers/firmware/arm_scmi/transports/virtio.c
index bd806e79ccff6..24bfcfd0df80c 100644
--- a/drivers/firmware/arm_scmi/transports/virtio.c
+++ b/drivers/firmware/arm_scmi/transports/virtio.c
@@ -373,7 +373,7 @@ static unsigned int virtio_get_max_msg(struct scmi_chan_info *base_cinfo)
        return vioch->max_msg;
 }
 
-static bool virtio_chan_available(struct device_node *of_node, int idx)
+static bool virtio_chan_available(struct fwnode_handle *node, int idx)
 {
        struct scmi_vio_channel *channels, *vioch = NULL;

[amazingfate]

Thanks for pointing this out! The defconfig in this repo has not set CONFIG_ARM_SCMI_TRANSPORT_VIRTIO so this issue is missed. I will update a new version with fix soon.