Skip to content

Commit ef61cf2

Browse files
committed
Document Android dismissible props as pending native support
1 parent 4e4be26 commit ef61cf2

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

packages/expo/android/src/main/java/expo/modules/clerk/ClerkAuthViewModule.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,9 @@ class ClerkAuthNativeView(context: Context, appContext: AppContext) : ClerkCompo
6767
AuthView(
6868
modifier = Modifier.fillMaxSize(),
6969
clerkTheme = Clerk.customTheme,
70-
isDismissable = isDismissible,
71-
onDismiss = if (isDismissible) ::sendDismissEvent else null,
70+
onDismiss = ::sendDismissEvent,
7271
onAuthComplete = {
73-
if (isDismissible) {
74-
sendDismissEvent()
75-
}
72+
sendDismissEvent()
7673
},
7774
)
7875
}
@@ -104,6 +101,9 @@ class ClerkAuthViewModule : Module() {
104101
}
105102

106103
Prop("isDismissible") { view: ClerkAuthNativeView, isDismissible: Boolean ->
104+
// clerk-android does not expose the iOS-parity isDismissible API yet.
105+
// Accept the prop for cross-platform RN API shape, and pass it through
106+
// once the native SDK owns this behavior.
107107
view.isDismissible = isDismissible
108108
}
109109

packages/expo/android/src/main/java/expo/modules/clerk/ClerkUserProfileViewModule.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,9 @@ class ClerkUserProfileViewModule : Module() {
6060
Events("onProfileEvent")
6161

6262
Prop("isDismissible") { view: ClerkUserProfileNativeView, isDismissible: Boolean ->
63+
// clerk-android does not expose the iOS-parity isDismissible API yet.
64+
// Accept the prop for cross-platform RN API shape, and pass it through
65+
// once the native SDK owns this behavior.
6366
view.isDismissible = isDismissible
6467
}
6568

0 commit comments

Comments
 (0)