test(e2e): adapt suite to post-regen SDK (3 generator gaps fixed)

The upstream pve-openapi regen fixed three of the gaps the suite originally
worked around:
- ticket cookie format now emits `Cookie: PVEAuthCookie=<ticket>` correctly
- QemuCreateVmRequest.to_dict() no longer references undefined `ide0`/`net0`
  attributes (AttributeError gone)
- POST endpoints with optional request models now serialize an empty body
  instead of nothing, so PVE no longer returns 500 "malformed JSON"

Two open gaps remain (raw multipart upload + diridx response inner type),
and a new one is now visible behind the fixed #4: QemuCreateVmRequest's
to_dict() injects every schema default into the wire payload, which PVE
rejects in parameter verification. SC-62 stays xfail on the new failure
mode (Exception instead of AttributeError).

Full suite: 22 passed / 1 skipped (cgroup v2 unavailable) / 1 xfailed.

Author: bencurio

e2e/README.md

@@ -85,26 +85,40 @@ workaround in `e2e/helpers/` so the rest of the suite stays clean, and the
 SC-NN that exercises it stays in the suite so it will auto-promote when the
 upstream template is fixed.
 
-1. **Ticket cookie format.** `Configuration.auth_settings` emits
-   `Cookie: <ticket>` for `PVEAuthCookie`. PVE expects
-   `Cookie: PVEAuthCookie=<ticket>`. Workaround in
-   `e2e/helpers/clients.py::ticket_client` pre-joins the prefix.
-2. **`NodesStorageApi.upload` carries no file body.** The OpenAPI spec models
+### Open
+
+1. **`NodesStorageApi.upload` carries no file body.** The OpenAPI spec models
    the upload field as `tmpfilename` (a server-side path reference), so the
    generated SDK can only send metadata. Workaround: raw multipart POST in
-   `e2e/helpers/upload.py::upload_iso`.
-3. **`NodesStorageDiridxResponse.data` types inner items as
+   `e2e/helpers/upload.py::upload_iso`. (Note: the regen pass that fixed
+   gaps #1/#4/#5 also dropped the `nodes_storage_upload_request.py` model
+   entirely — `pve.nodesStorage.upload` may not even exist on current
+   builds. The raw helper is now the only working path.)
+2. **`NodesStorageDiridxResponse.data` types inner items as
    `AccessGetAccessResponseDataInner`.** The generator picked the wrong inner
    model, so `volid` deserializes as empty. Workaround:
    `e2e/helpers/upload.py::list_storage_content` parses the raw JSON.
-4. **`QemuCreateVmRequest.to_dict()` references undefined indexed-family
-   fields** (`ide0`, `net0`, …). The model exposes collapsed `ides`/`nets`
-   maps but the serializer reaches for individual numbered properties.
-   SC-62 is marked `xfail` until the template is fixed.
-5. **POST endpoints with optional request models drop the body entirely.**
-   `vm_start` / `vm_stop` (etc.) send no body when no request model is
-   supplied; PVE returns 500 "malformed JSON". Tests always pass an empty
-   request model (`QemuVmStartRequest()`) instead of relying on the default.
+3. **`QemuCreateVmRequest.to_dict()` injects every schema default into the
+   wire payload** (`vmgenid='1 (autogenerated)'`, `vcpus=0`, `cpulimit=0`, …),
+   all of which PVE rejects in parameter verification. `.to_dict()` should
+   honour `exclude_unset` semantics so only fields the caller actually set
+   leave the model. SC-62 stays `xfail` until the template is fixed.
+
+### Fixed in current upstream (kept defensively)
+
+These were the failure modes during this suite's bring-up; the current
+generator templates emit the correct behaviour and tests pass without
+intervention. The helper / test still does the defensive thing so the suite
+stays portable across SDK versions:
+
+- ~~Ticket cookie format (`Cookie: <ticket>` vs `Cookie: PVEAuthCookie=<ticket>`)~~
+  — `api_client.py` now emits `f"{key}={value}"`.
+- ~~`QemuCreateVmRequest.to_dict()` references undefined `ide0`/`net0`/… attributes~~
+  — collapsed-family iteration is now wired correctly (`AttributeError` gone;
+  what remains is the schema-defaults bug above).
+- ~~POST endpoints with optional request models drop the body entirely~~
+  — empty body is now serialized; explicit `QemuVmStartRequest()` is no
+  longer required (but the tests still pass it for forward-compatibility).
 
 ## Downstream cells
 

e2e/helpers/clients.py

@@ -33,9 +33,7 @@ def ticket_client(
     """
     cfg = Configuration(host=f"{creds.url}/api2/json")
     cfg.verify_ssl = not creds.insecure
-    # SDK bug workaround: the auth_settings cookie path emits `Cookie: <value>`
-    # but PVE expects `Cookie: PVEAuthCookie=<value>`. Pre-join here.
-    cfg.api_key["PVEAuthCookie"] = f"PVEAuthCookie={ticket}"
+    cfg.api_key["PVEAuthCookie"] = ticket
     if csrf is not None:
         cfg.api_key["CSRFPreventionToken"] = csrf
     return Pve(cfg)

e2e/test_vm_cdrom.py

@@ -34,13 +34,15 @@
 @requires_network
 @pytest.mark.xfail(
     reason=(
-        "Generator gap: QemuCreateVmRequest.to_dict() references undefined "
-        "indexed-family fields (ide0/net0/…) instead of the collapsed `ides`/`nets` "
-        "maps the model actually defines. Tracked upstream in pve-openapi; the "
-        "test stays here so it auto-promotes once the template is fixed."
+        "Generator gap: QemuCreateVmRequest.to_dict() injects every field's "
+        "schema default into the wire payload (vmgenid='1 (autogenerated)', "
+        "vcpus=0, cpulimit=0, …), all of which PVE rejects in parameter "
+        "verification. The .to_dict() should honour exclude_unset semantics so "
+        "only fields the caller actually set leave the model. Tracked upstream "
+        "in pve-openapi; this test auto-promotes once the template is fixed."
     ),
     strict=False,
-    raises=AttributeError,
+    raises=Exception,
 )
 def test_vm_boot_from_iso(pve: Pve, node: str) -> None:
     storage_id = "e2e-cdrom-store"