From b64bcdf748bab0cafce4d832599b04b6f6e1be8a Mon Sep 17 00:00:00 2001 From: Yongtae Park Date: Sat, 22 Feb 2025 17:02:04 +0900 Subject: [PATCH 1/2] chore(data-table): solve transform data-table update bug Signed-off-by: samuel.park --- .../_components/WidgetFormDataTableCardTransformContents.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardTransformContents.vue b/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardTransformContents.vue index d019953a45..7a24449c1d 100644 --- a/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardTransformContents.vue +++ b/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardTransformContents.vue @@ -251,7 +251,6 @@ const { mutateAsync: updateWidget } = useMutation({ : keys.publicWidgetQueryKey; queryClient.setQueryData(widgetQueryKey.value, () => data); showSuccessMessage(i18n.t('COMMON.WIDGETS.DATA_TABLE.FORM.UPDATE_DATA_TALBE_INVALID_SUCCESS'), ''); - widgetGenerateStore.setSelectedDataTableId(state.dataTableId); }, onError: (e) => { showErrorMessage(e.message, e); @@ -431,6 +430,7 @@ const handleUpdateDataTable = async () => { state: 'INACTIVE', options: sanitizedOptions, }); + widgetGenerateStore.setSelectedDataTableId(result.data_table_id); await cascadeUpdateDataTable(result.data_table_id); } setTimeout(() => { From 7196ba4e2ed8a5329ab68b32980ad28db668ce9c Mon Sep 17 00:00:00 2001 From: Yongtae Park Date: Sat, 22 Feb 2025 17:45:18 +0900 Subject: [PATCH 2/2] fix(data-table): improve data-table cascading update UX Signed-off-by: samuel.park --- .../WidgetFormDataTableCardAddContents.vue | 4 +- .../WidgetFormDataTableCardFooter.vue | 6 +- ...dgetFormDataTableCardTransformContents.vue | 6 +- .../use-data-table-cascade-update.ts | 77 +++++++++++++------ .../widgets/_store/widget-generate-store.ts | 5 ++ 5 files changed, 66 insertions(+), 32 deletions(-) diff --git a/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardAddContents.vue b/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardAddContents.vue index bbb59f4867..b6b67531db 100644 --- a/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardAddContents.vue +++ b/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardAddContents.vue @@ -82,7 +82,9 @@ const { } = useWidgetFormQuery({ widgetId: computed(() => widgetGenerateState.widgetId), }); -const { cascadeUpdateDataTable } = useDataTableCascadeUpdate({ +const { + cascadeUpdateDataTable, +} = useDataTableCascadeUpdate({ widgetId: computed(() => widgetGenerateState.widgetId), }); diff --git a/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardFooter.vue b/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardFooter.vue index 0938b6c461..9ec674d612 100644 --- a/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardFooter.vue +++ b/apps/web/src/common/modules/widgets/_components/WidgetFormDataTableCardFooter.vue @@ -1,5 +1,5 @@