From 6b0a0309ea9168de4be89ced31db02c98c34ed11 Mon Sep 17 00:00:00 2001 From: Wanjin Noh Date: Mon, 7 Apr 2025 16:34:49 +0900 Subject: [PATCH 01/22] fix: update function parameters to support optional values and improve null checks Signed-off-by: Wanjin Noh --- .../src/services/project/v2/ProjectContainer.vue | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/web/src/services/project/v2/ProjectContainer.vue b/apps/web/src/services/project/v2/ProjectContainer.vue index 34675203ec..162f40bb57 100644 --- a/apps/web/src/services/project/v2/ProjectContainer.vue +++ b/apps/web/src/services/project/v2/ProjectContainer.vue @@ -33,7 +33,7 @@ const state = reactive({ }); /* Event */ -const handleUpdateProjectFormModalVisible = (visible: boolean) => { +const handleUpdateProjectFormModalVisible = (visible?: boolean) => { projectPageStore.setProjectFormModalVisible(visible); if (projectPageState.currentSelectedProjectId && !visible) { projectPageStore.setCurrentSelectedProjectId(undefined); @@ -51,16 +51,16 @@ const refreshProejctTree = () => { projectTreeStore.refreshProjectTree(); }; -const handleConfirmProjectFormModal = (isCreating: boolean, result: ProjectModel) => { +const handleConfirmProjectFormModal = (isCreating: boolean, result?: ProjectModel) => { refreshProejctTree(); - if (isCreating && !result.project_group_id && !state.isProjectRootPage) { + if (isCreating && !result?.project_group_id && !state.isProjectRootPage) { // TODO: check route router.push({ name: PROJECT_ROUTE_V2._NAME }); } }; -const handleConfirmProjectGroupFormModal = (isCreating: boolean, result: ProjectGroupModel) => { +const handleConfirmProjectGroupFormModal = (isCreating: boolean, result?: ProjectGroupModel) => { refreshProejctTree(); - if (isCreating && !result.parent_group_id && !state.isProjectRootPage) { + if (isCreating && !result?.parent_group_id && !state.isProjectRootPage) { // TODO: check route router.push({ name: PROJECT_ROUTE_V2._NAME }); } @@ -75,7 +75,7 @@ onUnmounted(() => { - From 16972f8761080675adc3fd32215a42e7243c82fb Mon Sep 17 00:00:00 2001 From: Wanjin Noh Date: Mon, 7 Apr 2025 16:34:50 +0900 Subject: [PATCH 02/22] feat: add composables for project group queries and update ProjectMainProjectGroupFormModal Signed-off-by: Wanjin Noh --- .../ProjectMainProjectGroupFormModal.vue | 56 ++++++++++--------- .../queries/use-project-group-query.ts | 29 ++++++++++ .../queries/use-project-groups-query.ts | 28 ++++++++++ .../composables/use-project-group-names.ts | 23 ++++++++ 4 files changed, 110 insertions(+), 26 deletions(-) create mode 100644 apps/web/src/services/project/v-shared/composables/queries/use-project-group-query.ts create mode 100644 apps/web/src/services/project/v-shared/composables/queries/use-project-groups-query.ts create mode 100644 apps/web/src/services/project/v-shared/composables/use-project-group-names.ts diff --git a/apps/web/src/services/project/v-shared/components/ProjectMainProjectGroupFormModal.vue b/apps/web/src/services/project/v-shared/components/ProjectMainProjectGroupFormModal.vue index 171a9e3cb1..c0e1bf6cf7 100644 --- a/apps/web/src/services/project/v-shared/components/ProjectMainProjectGroupFormModal.vue +++ b/apps/web/src/services/project/v-shared/components/ProjectMainProjectGroupFormModal.vue @@ -1,21 +1,18 @@