Disable Request Notification Permission

[frknylmzcom2]

Hello, the plugin currently automatically asks for notification permission when the app is opened, can we add this to a config?

This is my current config, can we add one here like disableNotificationRegistration? Because there is already a place inside where we get notification permission. It seems like it is not user friendly to ask for notification permission as soon as the application is opened at first.

[
  'config-plugin-react-native-intercom',
    {
      androidApiKey: INTERCOM_ANDROID_API_KEY as string,
      iosApiKey: INTERCOM_IOS_API_KEY as string,
      appId: INTERCOM_APP_ID as string,
      isPushNotificationsEnabledAndroid: true,
      isPushNotificationsEnabledIOS: true,
    },
],

Thank You!

[elmaxe]

Are you sure this is an intercom issue and not an issue elsewhere in your code? I.e are you sure you're not calling requestNotificationPermissionsAsync on startup etc. Just making sure

[eexit]

Hello,

What OS are you referring to?
If iOS, just remove isPushNotificationsEnabledIOS from the config, and you're good to go, you'll be able to request for the permission whenever you wish in your app.

For Android, it should not request the permission upon the app start unless you request to add a new notification channel.

Hope this helps!

[frknylmzcom2]

Are you sure this is an intercom issue and not an issue elsewhere in your code? I.e are you sure you're not calling requestNotificationPermissionsAsync on startup etc. Just making sure

I don't think this is related to the intercom side, because the part that triggers the push notification permission is in the config package. Please see here;

config-plugin-react-native-intercom/packages/intercom-react-native/src/withIntercomIOS.ts

Lines 93 to 116 in e7f6033

	const initMethodInvocationBlock = `[IntercomModule initialize:`;
	const registerIntercomPushCode = `
	// START INTERCOM PUSH
	UNUserNotificationCenter *center = [UNUserNotificationCenter currentNotificationCenter];
	[center requestAuthorizationWithOptions:(UNAuthorizationOptionAlert + UNAuthorizationOptionSound)
	completionHandler:^(BOOL granted, NSError *_Nullable error) {
	}];
	[[UIApplication sharedApplication] registerForRemoteNotifications];
	// END INTERCOM PUSH
	`;
	const registerPushLine = `[IntercomModule setDeviceToken:deviceToken];`;
	const registerPushAnchor = `return [super application:application didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];`;
	// Add invocation
	if (!contents.includes(initMethodInvocationBlock)) {
	// TODO: Determine if this is safe
	contents = contents.replace(
	/return YES;/g,
	`${initMethodInvocationBlock}@"${apiKey}" withAppId:@"${appId}"];\n\n${
	pushNotifications ? registerIntercomPushCode : ""
	}\n\n\treturn YES;`
	);
	}

[frknylmzcom2]

Hello,

What OS are you referring to? If iOS, just remove isPushNotificationsEnabledIOS from the config, and you're good to go, you'll be able to request for the permission whenever you wish in your app.

For Android, it should not request the permission upon the app start unless you request to add a new notification channel.

Hope this helps!

Hello,
If I remove isPushNotificationsEnabledIOS, I cannot receive push notification by intercom, so when we reply to a user, if the app is not open, we want receive the push notification.

[noahsettersten]

I'll second the use case that @frknylmzcom2 is asking for. We want to be able to receive Intercom's push notifications on iOS in the app, but would like to disable the config plugin from asking for the permission. Then, we can ask the user for permission in our app code when it makes sense within the app instead of at launch.

We're using a solution based on the fork at https://github.com/EnhanceTech/config-plugin-react-native-intercom for now, but it would be great to have an additional option for the plugin. Perhaps something like requestPushNotificationsPermission: true/false that decides whether the config plugin adds the permission request or not.

Thanks for the work on this config plugin!

[patrickomeara]

I'll third the need for this feature. We have a screen explaining how notifications benefit the user that shows after login. Since implementing this AMAZING plugin, that screen has become a little confused as the permission has already been requested. We are also seeing more users deny the permission, which would be lovely to rectify.

This plugin is great, thanks for the hard work.

[itajenglish]

+1 any updates on this?

[ucakyunus]

+1 any updates on this?

[ovidb]

+1 on this. I've spent countless hours trying to figure out why do notifications show up at app start.

[itajenglish]

@patrickomeara, @ucakyunus, and @ovidb Feel free to use this patch file I created of @noahsettersten's solution.

https://gist.github.com/itajenglish/667791a5b97447f4c2ca2d5c10d54cd5

Patch Package: https://www.npmjs.com/package/patch-package

[ovidb]

@itajenglish do you do anything else besides this? If I do this for me Intercom doesn't seem to work anymore.

[itajenglish]

@itajenglish do you do anything else besides this? If I do this for me Intercom doesn't seem to work anymore.

@ovidb This is working for us. What seems to be the problem exactly?

[ovidb]

@itajenglish
I'm now getting this error when I'm trying to send the token to Intercom

 ERROR  Invariant Violation: No callback found with cbID 11392 and callID 5696 for  IntercomModule.sendTokenToIntercom - most likely the callback was already invoked. Args: '[true]', js engine: hermes

And I'm not receiving any messages from intercom, nor can I instantiate it on my side

[itajenglish]

@itajenglish

I'm now getting this error when I'm trying to send the token to Intercom

 ERROR  Invariant Violation: No callback found with cbID 11392 and callID 5696 for  IntercomModule.sendTokenToIntercom - most likely the callback was already invoked. Args: '[true]', js engine: hermes

And I'm not receiving any messages from intercom, nor can I instantiate it on my side

@ovidb that's odd. Let's jump on a video call and I can help you troubleshoot https://meet.google.com/zem-rtdh-jps