You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 16, 2024. It is now read-only.
However, I would like to report something broken. I'm not React Native expert but according to Intercom documentation, some carousels can trigger for device permission. Which is great and offload all the permission request logic to the Intercom code.
For the push notification permission, I noticed that the carousel is always considering that the permission is granted on Android.
Steps to reproduce:
Create an Intercom carousel with "Push notification" for the Button Action
Set it live and copy its ID
In the App, do an Intercom login and trigger a await Intercom.presentContent(IntercomContent.carouselWithCarouselId(copiedCarouselId));
The carousel launches as expected
The "Button Action" is filled with a tick icon instead of displaying 2 buttons (meaning the permission is already granted)
After some digging, the issue seems to be related to the MainNotificationService being injected to the Android source code. I believe this service is required to receive notifications but I suspect the call to IntercomModule.sendTokenToIntercom(getApplication(), refreshedToken) to register the device Intercom and flag the device has "granted for push notifications" while it's not the case.
Is there any chance we could sort this out so we could leverale this Intercom feature?
Hello,
Firstly, thank you for your plugin. Very useful.
However, I would like to report something broken. I'm not React Native expert but according to Intercom documentation, some carousels can trigger for device permission. Which is great and offload all the permission request logic to the Intercom code.
For the push notification permission, I noticed that the carousel is always considering that the permission is granted on Android.
Steps to reproduce:
await Intercom.presentContent(IntercomContent.carouselWithCarouselId(copiedCarouselId));Doc: https://www.intercom.com/help/en/articles/4164612-design-and-build-a-mobile-carousel#things-to-note-about-requesting-device-permissions
Tested with:
@intercom/intercom-react-native@^4.0.1config-plugin-react-native-intercom@mainexpo@~48.0.6After some digging, the issue seems to be related to the
MainNotificationServicebeing injected to the Android source code. I believe this service is required to receive notifications but I suspect the call toIntercomModule.sendTokenToIntercom(getApplication(), refreshedToken)to register the device Intercom and flag the device has "granted for push notifications" while it's not the case.Is there any chance we could sort this out so we could leverale this Intercom feature?
Thanks!