Skip to content

Commit 7c63357

Browse files
refactor: remove redundant manual pagination parameter parsing from job controller
Removed manual parseInt() logic for skip and first parameters since @type() decorators in PaginationArgs now handle automatic transformation. This eliminates duplicate parameter handling and potential conflicts.
1 parent f916f1b commit 7c63357

File tree

1 file changed

+3
-33
lines changed

1 file changed

+3
-33
lines changed

src/jobs/job.controller.ts

Lines changed: 3 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -101,18 +101,8 @@ export class JobController {
101101
async findByCompany(
102102
@Param('companyId', ParseIntPipe) companyId: number,
103103
@Query() paginationArgs: PaginationArgs,
104-
@Query() orderBy: JobOrderByDto,
105-
@Query('skip') skipParam?: string,
106-
@Query('first') firstParam?: string
104+
@Query() orderBy: JobOrderByDto
107105
) {
108-
// Ensure pagination parameters are properly converted to numbers
109-
if (skipParam) {
110-
paginationArgs.skip = parseInt(skipParam, 10);
111-
}
112-
if (firstParam) {
113-
paginationArgs.first = parseInt(firstParam, 10);
114-
}
115-
116106
return this.jobService.findByCompany(companyId, paginationArgs, orderBy);
117107
}
118108

@@ -132,18 +122,8 @@ export class JobController {
132122
async findByTag(
133123
@Param('tagName') tagName: string,
134124
@Query() paginationArgs: PaginationArgs,
135-
@Query() orderBy: JobOrderByDto,
136-
@Query('skip') skipParam?: string,
137-
@Query('first') firstParam?: string
125+
@Query() orderBy: JobOrderByDto
138126
) {
139-
// Ensure pagination parameters are properly converted to numbers
140-
if (skipParam) {
141-
paginationArgs.skip = parseInt(skipParam, 10);
142-
}
143-
if (firstParam) {
144-
paginationArgs.first = parseInt(firstParam, 10);
145-
}
146-
147127
return this.jobService.findByTag(tagName, paginationArgs, orderBy);
148128
}
149129

@@ -187,18 +167,8 @@ export class JobController {
187167
@Query('companyId', new ParseIntPipe({ optional: true })) companyId?: number,
188168
@Query('location') location?: string,
189169
@Query('isRemote') isRemote?: boolean,
190-
@Query('tags') tags?: string,
191-
@Query('skip') skipParam?: string,
192-
@Query('first') firstParam?: string
170+
@Query('tags') tags?: string
193171
) {
194-
// Ensure pagination parameters are properly converted to numbers
195-
if (skipParam) {
196-
paginationArgs.skip = parseInt(skipParam, 10);
197-
}
198-
if (firstParam) {
199-
paginationArgs.first = parseInt(firstParam, 10);
200-
}
201-
202172
console.log('Pagination params:', { skip: paginationArgs.skip, first: paginationArgs.first });
203173

204174
return this.jobService.findAll({

0 commit comments

Comments
 (0)