fix: switchTo throws error when passing strict locator (#3847)

* fix: switchTo throws error when passing css locator

* fix: switchTo

* fix: improvements for within

* fix: puppeteer within issue

Author: kobenguyent

lib/helper/Playwright.js

@@ -850,8 +850,8 @@ class Playwright extends Helper {
         await this.switchTo(null);
         return frame.reduce((p, frameLocator) => p.then(() => this.switchTo(frameLocator)), Promise.resolve());
       }
-      await this.switchTo(locator);
-      this.withinLocator = new Locator(locator);
+      await this.switchTo(frame);
+      this.withinLocator = new Locator(frame);
       return;
     }
 
@@ -2552,22 +2552,25 @@ class Playwright extends Helper {
 
     // iframe by selector
     const els = await this._locate(locator);
-    // assertElementExists(els, locator);
+    if (!els[0]) {
+      throw new Error(`Element ${JSON.stringify(locator)} was not found by text|CSS|XPath`);
+    }
 
     // get content of the first iframe
-    if ((locator.frame && locator.frame === 'iframe') || locator.toLowerCase() === 'iframe') {
+    locator = new Locator(locator, 'css');
+    if ((locator.frame && locator.frame === 'iframe') || locator.value.toLowerCase() === 'iframe') {
       contentFrame = await this.page.frames()[1];
       // get content of the iframe using its name
-    } else if (locator.toLowerCase().includes('name=')) {
-      const frameName = locator.split('=')[1].replace(/"/g, '').replaceAll(/]/g, '');
+    } else if (locator.value.toLowerCase().includes('name=')) {
+      const frameName = locator.value.split('=')[1].replace(/"/g, '').replaceAll(/]/g, '');
       contentFrame = await this.page.frame(frameName);
     }
 
     if (contentFrame) {
       this.context = contentFrame;
       this.contextLocator = null;
     } else {
-      this.context = els[0];
+      this.context = this.page.frame(this.page.frames()[1].name());
       this.contextLocator = locator;
     }
   }
@@ -3515,7 +3518,10 @@ async function elementSelected(element) {
 
 function isFrameLocator(locator) {
   locator = new Locator(locator);
-  if (locator.isFrame()) return locator.value;
+  if (locator.isFrame()) {
+    const _locator = new Locator(locator.value);
+    return _locator.value;
+  }
   return false;
 }
 

lib/helper/Puppeteer.js

@@ -604,8 +604,8 @@ class Puppeteer extends Helper {
         return this.switchTo(null)
           .then(() => frame.reduce((p, frameLocator) => p.then(() => this.switchTo(frameLocator)), Promise.resolve()));
       }
-      await this.switchTo(locator);
-      this.withinLocator = new Locator(locator);
+      await this.switchTo(frame);
+      this.withinLocator = new Locator(frame);
       return;
     }
 
@@ -2606,7 +2606,10 @@ async function elementSelected(element) {
 
 function isFrameLocator(locator) {
   locator = new Locator(locator);
-  if (locator.isFrame()) return locator.value;
+  if (locator.isFrame()) {
+    const _locator = new Locator(locator);
+    return _locator.value;
+  }
   return false;
 }
 

test/data/app/view/iframe.php

@@ -7,7 +7,7 @@
 
 <h1>Iframe test</h1>
 
-<iframe name="content" src="info" />
+<iframe name="content" src="info" id="number-frame-1234"/>
 
 </body>
-</html>
+</html>

test/helper/webapi.js

@@ -455,7 +455,7 @@ module.exports.tests = function () {
       if (isHelper('TestCafe')) this.skip(); // TODO Not yet implemented
 
       await I.amOnPage('/iframe');
-      await I.switchTo('iframe');
+      await I.switchTo({ css: 'iframe' });
       const val = await I.executeScript(() => document.getElementsByTagName('h1')[0].innerText);
       assert.equal(val, 'Information');
     });
@@ -1199,6 +1199,36 @@ module.exports.tests = function () {
         if (!err) assert.fail('seen "Iframe test"');
       }
     });
+
+    it('within should respect context in see when using frame', async function () {
+      if (isHelper('TestCafe')) this.skip();
+
+      await I.amOnPage('/iframe');
+      await I._withinBegin({
+        frame: '#number-frame-1234',
+      });
+
+      try {
+        await I.see('Information');
+      } catch (err) {
+        if (!err) assert.fail('seen "Information"');
+      }
+    });
+
+    it('within should respect context in see when using frame with strict locator', async function () {
+      if (isHelper('TestCafe')) this.skip();
+
+      await I.amOnPage('/iframe');
+      await I._withinBegin({
+        frame: { css: '#number-frame-1234' },
+      });
+
+      try {
+        await I.see('Information');
+      } catch (err) {
+        if (!err) assert.fail('seen "Information"');
+      }
+    });
   });
 
   describe('scroll: #scrollTo, #scrollPageToTop, #scrollPageToBottom', () => {