chore: update PHPStan baseline and Rector config (#10431)

* fix phpstan

* fix rector

Author: michalsn

rector.php

@@ -25,6 +25,7 @@
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
 use Rector\DeadCode\Rector\MethodCall\RemoveNullArgOnNullDefaultParamRector;
+use Rector\DeadCode\Rector\Property\RemoveDefaultValueFromAssignedPropertyRector;
 use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
 use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
 use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
@@ -33,6 +34,7 @@
 use Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector;
 use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
 use Rector\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector;
+use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
 use Rector\PHPUnit\CodeQuality\Rector\FuncCall\AssertFuncCallToPHPUnitAssertRector;
 use Rector\PHPUnit\CodeQuality\Rector\StmtsAwareInterface\DeclareStrictTypesTestsRector;
@@ -102,6 +104,16 @@
             __DIR__ . '/system/HTTP/Response.php',
         ],
 
+        // Keep property defaults for backward compatibility.
+        RemoveDefaultValueFromAssignedPropertyRector::class,
+
+        ReadOnlyPropertyRector::class => [
+            __DIR__ . '/system/Cache/ResponseCache.php',
+            __DIR__ . '/system/HotReloader/IteratorFilter.php',
+            __DIR__ . '/system/Router/RouteCollection.php',
+            __DIR__ . '/system/Security/Security.php',
+        ],
+
         // Exclude test file because `is_cli()` is mocked and Rector might remove needed parameters.
         RemoveExtraParametersRector::class => [
             __DIR__ . '/tests/system/Debug/ToolbarTest.php',

system/Config/Services.php

@@ -343,7 +343,6 @@ public static function image(?string $handler = null, ?Images $config = null, bo
         }
 
         $config ??= config(Images::class);
-        assert($config instanceof Images);
 
         $handler = in_array($handler, [null, '', '0'], true) ? $config->defaultHandler : $handler;
         $class   = $config->handlers[$handler];

system/Router/RouteCollection.php

@@ -1335,7 +1335,7 @@ protected function fillRouteParams(string $from, ?array $params = null): string
 
             // Ensure that the param we're inserting matches
             // the expected param type.
-            $pos  = strpos($from, $pattern);
+            $pos  = strpos($from, (string) $pattern);
             $from = substr_replace($from, $params[$index], $pos, strlen($pattern));
         }
 
@@ -1397,7 +1397,7 @@ protected function buildReverseRoute(string $from, array $params): string
 
             // Ensure that the param we're inserting matches
             // the expected param type.
-            $pos  = strpos($from, $placeholder);
+            $pos  = strpos($from, (string) $placeholder);
             $from = substr_replace($from, (string) $params[$index], $pos, strlen($placeholder));
         }
 

tests/system/AutoReview/FrameworkCodeTest.php

@@ -62,7 +62,6 @@ public function testEachTestClassHasCorrectGroupAttributeName(string $class): vo
         $unrecognizedGroups = array_diff(
             array_map(static function (ReflectionAttribute $attribute): string {
                 $groupAttribute = $attribute->newInstance();
-                assert($groupAttribute instanceof Group);
 
                 return $groupAttribute->name();
             }, $attributes),

tests/system/Database/Live/GetNumRowsTest.php

@@ -29,28 +29,6 @@ final class GetNumRowsTest extends CIUnitTestCase
     protected $refresh = true;
     protected $seed    = CITestSeeder::class;
 
-    /**
-     * Added as instructed at https://codeigniter4.github.io/userguide/testing/database.html#the-test-class
-     * {@inheritDoc}
-     *
-     * @see \CodeIgniter\Test\CIDatabaseTestCase::setUp()
-     */
-    protected function setUp(): void
-    {
-        parent::setUp();
-    }
-
-    /**
-     * Added as instructed at https://codeigniter4.github.io/userguide/testing/database.html#the-test-class
-     * {@inheritDoc}
-     *
-     * @see \CodeIgniter\Test\CIDatabaseTestCase::tearDown()
-     */
-    protected function tearDown(): void
-    {
-        parent::tearDown();
-    }
-
     /**
      * tests newly added ResultInterface::getNumRows with a live db
      */

tests/system/Database/Migrations/MigrationTest.php

@@ -26,11 +26,6 @@ final class MigrationTest extends CIUnitTestCase
 {
     use DatabaseTestTrait;
 
-    protected function setUp(): void
-    {
-        parent::setUp();
-    }
-
     public function testDBGroup(): void
     {
         $migration = new class () extends Migration {

tests/system/Models/GeneralModelTest.php

@@ -35,11 +35,6 @@ final class GeneralModelTest extends CIUnitTestCase
      */
     private ?object $model = null;
 
-    protected function setUp(): void
-    {
-        parent::setUp();
-    }
-
     protected function tearDown(): void
     {
         parent::tearDown();

tests/system/Models/LiveModelTestCase.php

@@ -38,11 +38,6 @@ abstract class LiveModelTestCase extends CIUnitTestCase
 
     protected $seed = CITestSeeder::class;
 
-    protected function setUp(): void
-    {
-        parent::setUp();
-    }
-
     protected function tearDown(): void
     {
         parent::tearDown();

tests/system/Test/TestResponseTest.php

@@ -29,11 +29,6 @@ final class TestResponseTest extends CIUnitTestCase
     private ?TestResponse $testResponse = null;
     private Response $response;
 
-    protected function setUp(): void
-    {
-        parent::setUp();
-    }
-
     #[DataProvider('provideHttpStatusCodes')]
     public function testIsOK(int $code, bool $isOk): void
     {

utils/phpstan-baseline/empty.notAllowed.neon

@@ -1,4 +1,4 @@
-# total 212 errors
+# total 205 errors
 
 parameters:
     ignoreErrors: