Login redirection fix

Author: Rajat

apps/web/app/login/page.tsx

@@ -1,5 +1,8 @@
 import { redirect } from "next/navigation";
-import { API_URL, WEB_CLIENT } from "@/lib/config";
+import { API_PUBLIC_URL, WEB_CLIENT } from "@/lib/config";
+import { getDashboardLoginUrl } from "@/lib/login-url";
+
+export const dynamic = "force-dynamic";
 
 /**
  * `apps/api` hosts the only login UI (see the "Unified Login Screen"
@@ -8,6 +11,10 @@ import { API_URL, WEB_CLIENT } from "@/lib/config";
  * bounces the browser there and back.
  */
 export default function LoginPage() {
-    const target = `${API_URL}/login?redirect=${encodeURIComponent(`${WEB_CLIENT}/dashboard`)}`;
-    redirect(target);
+    redirect(
+        getDashboardLoginUrl({
+            apiPublicUrl: API_PUBLIC_URL,
+            webClient: WEB_CLIENT,
+        }),
+    );
 }

apps/web/lib/config.ts

@@ -1,6 +1,8 @@
 import { DEFAULT_MAX_UPLOAD_SIZE_BYTES } from "@/lib/media-limits";
 
 export const API_URL = process.env.API_URL || "http://localhost:4000";
+export const API_PUBLIC_URL =
+    process.env.API_PUBLIC_URL || "http://localhost:4000";
 
 /** This app's own public origin — sent to `apps/api`'s hosted login page
  * (`GET /login?redirect=...`) as where to bounce the browser back to after

apps/web/lib/login-url.test.ts

@@ -0,0 +1,15 @@
+import { describe, expect, it } from "vitest";
+import { getDashboardLoginUrl } from "./login-url";
+
+describe("dashboard login redirect", () => {
+    it("uses the public API URL for browser redirects", () => {
+        expect(
+            getDashboardLoginUrl({
+                apiPublicUrl: "https://api.sendlit.com",
+                webClient: "https://app.sendlit.com",
+            }),
+        ).toBe(
+            "https://api.sendlit.com/login?redirect=https%3A%2F%2Fapp.sendlit.com%2Fdashboard",
+        );
+    });
+});

apps/web/lib/login-url.ts

@@ -0,0 +1,11 @@
+type LoginUrlInput = {
+    apiPublicUrl: string;
+    webClient: string;
+};
+
+export function getDashboardLoginUrl({
+    apiPublicUrl,
+    webClient,
+}: LoginUrlInput): string {
+    return `${apiPublicUrl}/login?redirect=${encodeURIComponent(`${webClient}/dashboard`)}`;
+}