Skip to content

Commit f69c40d

Browse files
committed
Uncomment tests that reveal defects in the code
Signed-off-by: John Rofrano <johnnyroy@johnrofrano.com>
1 parent 26bf06d commit f69c40d

1 file changed

Lines changed: 23 additions & 23 deletions

File tree

tests/analysis/java/test_java_analysis.py

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1071,10 +1071,10 @@ def test_remove_all_comments(test_fixture, analysis_json):
10711071

10721072
# TODO: The code is broken. It requires Treesitter but JCodeanalyzer does not!
10731073

1074-
# code = java_analysis.remove_all_comments()
1075-
# assert code is not None
1076-
# assert isinstance(code, str)
1077-
# assert len(code) > 0
1074+
code = java_analysis.remove_all_comments()
1075+
assert code is not None
1076+
assert isinstance(code, str)
1077+
assert len(code) > 0
10781078

10791079
# Test with unsupported backend
10801080
java_analysis.analysis_backend = AnalysisEngine.CODEQL
@@ -1103,13 +1103,13 @@ def test_get_methods_with_annotations(test_fixture, analysis_json):
11031103

11041104
# TODO: The code is broken. It requires Treesitter but JCodeanalyzer does not!
11051105

1106-
# annotations = ["WebServlet"]
1107-
# code_with_annotations = java_analysis.get_methods_with_annotations(annotations)
1108-
# assert code_with_annotations is not None
1109-
# assert isinstance(code_with_annotations, Dict)
1110-
# assert len(code_with_annotations) > 0
1111-
# for _, code in code_with_annotations.items():
1112-
# assert isinstance(code, Dict)
1106+
annotations = ["WebServlet"]
1107+
code_with_annotations = java_analysis.get_methods_with_annotations(annotations)
1108+
assert code_with_annotations is not None
1109+
assert isinstance(code_with_annotations, Dict)
1110+
assert len(code_with_annotations) > 0
1111+
for _, code in code_with_annotations.items():
1112+
assert isinstance(code, Dict)
11131113

11141114
# Test with unsupported backend
11151115
java_analysis.analysis_backend = AnalysisEngine.CODEQL
@@ -1138,10 +1138,10 @@ def test_get_test_methods(test_fixture, analysis_json):
11381138

11391139
# TODO: The code is broken. It requires Treesitter but JCodeanalyzer does not!
11401140

1141-
# test_methods = java_analysis.get_test_methods()
1142-
# assert test_methods is not None
1143-
# assert isinstance(test_methods, Dict)
1144-
# assert len(test_methods) > 0
1141+
test_methods = java_analysis.get_test_methods()
1142+
assert test_methods is not None
1143+
assert isinstance(test_methods, Dict)
1144+
assert len(test_methods) > 0
11451145

11461146
# Test with unsupported backend
11471147
java_analysis.analysis_backend = AnalysisEngine.CODEQL
@@ -1170,10 +1170,10 @@ def test_get_calling_lines(test_fixture, analysis_json):
11701170

11711171
# TODO: The code is broken. It requires Treesitter but JCodeanalyzer does not!
11721172

1173-
# calling_lines = java_analysis.get_calling_lines("trace(String)")
1174-
# assert calling_lines is not None
1175-
# assert isinstance(calling_lines, List)
1176-
# assert len(calling_lines) > 0
1173+
calling_lines = java_analysis.get_calling_lines("trace(String)")
1174+
assert calling_lines is not None
1175+
assert isinstance(calling_lines, List)
1176+
assert len(calling_lines) > 0
11771177

11781178
# Test with unsupported backend
11791179
java_analysis.analysis_backend = AnalysisEngine.CODEQL
@@ -1202,10 +1202,10 @@ def test_get_call_targets(test_fixture, analysis_json):
12021202

12031203
# TODO: The code is broken. It requires Treesitter but JCodeanalyzer does not!
12041204

1205-
# call_targets = java_analysis.get_call_targets("trace(String)")
1206-
# assert call_targets is not None
1207-
# assert isinstance(call_targets, Set)
1208-
# assert len(call_targets) > 0
1205+
call_targets = java_analysis.get_call_targets("trace(String)")
1206+
assert call_targets is not None
1207+
assert isinstance(call_targets, Set)
1208+
assert len(call_targets) > 0
12091209

12101210
# Test with unsupported backend
12111211
java_analysis.analysis_backend = AnalysisEngine.CODEQL

0 commit comments

Comments
 (0)