From ac7134a474fbc70c515bd42f995c7294e9763680 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Berardo=20Mate=CC=80?= Date: Thu, 9 Apr 2026 16:18:21 +0200 Subject: [PATCH 1/3] fix: improve dropdown & select --- packages/app-elements/src/styles/global.css | 6 +-- packages/app-elements/src/ui/atoms/Tag.tsx | 4 +- .../ui/composite/Dropdown/DropdownDivider.tsx | 2 +- .../ui/composite/Dropdown/DropdownItem.tsx | 4 +- .../ui/composite/Dropdown/DropdownMenu.tsx | 8 ++-- .../ui/composite/Dropdown/DropdownSearch.tsx | 4 +- .../__snapshots__/Dropdown.test.tsx.snap | 24 +++++----- .../src/ui/forms/InputSelect/styles.ts | 46 ++++++++++--------- 8 files changed, 50 insertions(+), 48 deletions(-) diff --git a/packages/app-elements/src/styles/global.css b/packages/app-elements/src/styles/global.css index fbbefa9df..6db9fa76a 100644 --- a/packages/app-elements/src/styles/global.css +++ b/packages/app-elements/src/styles/global.css @@ -9,9 +9,9 @@ --breakpoint-xl: 1280px; --radius-*: initial; - --radius: 0.313rem; - --radius-sm: 0.188rem; - --radius-md: 0.625rem; + --radius: 0.5rem; + --radius-sm: 0.375rem; + --radius-md: 1rem; --radius-full: 9999px; --color-*: initial; diff --git a/packages/app-elements/src/ui/atoms/Tag.tsx b/packages/app-elements/src/ui/atoms/Tag.tsx index f38dac872..ebba77ac5 100644 --- a/packages/app-elements/src/ui/atoms/Tag.tsx +++ b/packages/app-elements/src/ui/atoms/Tag.tsx @@ -103,8 +103,8 @@ export const Tag: FC = ({ icon, children, className, ...rest }) => { className={cn([ className, "flex gap-2 items-center select-none", - "text-xs font-bold", - "py-[3px] px-2 rounded text-gray bg-gray-200", + "text-xs font-semibold", + "py-[3px] px-2 rounded-sm text-gray bg-gray-200", { "cursor-pointer hover:bg-gray-100 outline-primary-light": hasHover, }, diff --git a/packages/app-elements/src/ui/composite/Dropdown/DropdownDivider.tsx b/packages/app-elements/src/ui/composite/Dropdown/DropdownDivider.tsx index 0c354d6f7..8f77d45d4 100644 --- a/packages/app-elements/src/ui/composite/Dropdown/DropdownDivider.tsx +++ b/packages/app-elements/src/ui/composite/Dropdown/DropdownDivider.tsx @@ -11,7 +11,7 @@ export const DropdownDivider: FC = ({ }) => { return (
-
+
) } diff --git a/packages/app-elements/src/ui/composite/Dropdown/DropdownItem.tsx b/packages/app-elements/src/ui/composite/Dropdown/DropdownItem.tsx index fe6eb6d13..5c38818ae 100644 --- a/packages/app-elements/src/ui/composite/Dropdown/DropdownItem.tsx +++ b/packages/app-elements/src/ui/composite/Dropdown/DropdownItem.tsx @@ -61,14 +61,14 @@ export const DropdownItem = withSkeletonTemplate( }} href={href} className={cn( - "w-full bg-black text-white! py-1.5 pl-4 text-sm font-medium flex items-center focus:outline-hidden!", + "w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-4 mx-2 text-sm font-regular flex items-center focus:outline-hidden!", { "pr-8": info == null, "min-w-[250px] pr-6": info != null, }, className, { - "hover:bg-gray-600 cursor-pointer focus:bg-gray-600 group": + "hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group": onClick != null || href != null, "cursor-default": onClick == null && href == null, "opacity-50 pointer-events-none": isDisabled, diff --git a/packages/app-elements/src/ui/composite/Dropdown/DropdownMenu.tsx b/packages/app-elements/src/ui/composite/Dropdown/DropdownMenu.tsx index 5c6e30843..b62116297 100644 --- a/packages/app-elements/src/ui/composite/Dropdown/DropdownMenu.tsx +++ b/packages/app-elements/src/ui/composite/Dropdown/DropdownMenu.tsx @@ -55,17 +55,17 @@ export const DropdownMenu: FC = ({
{menuHeader != null && ( <>
{menuHeader} @@ -111,7 +111,7 @@ const Arrow: FC<{ return ( ( ) return ( -
+
( /> Should be rendering bottom-left 1`] = ` class="flex flex-col items-start" >
@@ -76,11 +76,11 @@ exports[`Dropdown > Should be rendering top-left 1`] = ` class="flex flex-col-reverse items-start" >
@@ -121,11 +121,11 @@ exports[`Dropdown > Should be rendering top-right 1`] = ` class="flex flex-col-reverse items-end" >
@@ -166,15 +166,15 @@ exports[`Dropdown > Should be rendering with default bottom-right position 1`] = class="flex flex-col items-end" >
) - expect(getByRole("button").className).toContain("px-4 h-9") + expect(getByRole("button").className).toContain("px-4") + expect(getByRole("button").className).toContain("h-9") }) it("Should render as size regular (default)", () => { const { getByRole } = render() - expect(getByRole("button").className).toContain("px-4 h-10") + expect(getByRole("button").className).toContain("px-4") + expect(getByRole("button").className).toContain("h-10") }) it("Should render with flex alignment", () => { const { getByRole } = render() - expect(getByRole("button").className).toContain("flex gap-1 items-center") + expect(getByRole("button").className).toContain("inline-flex") + expect(getByRole("button").className).toContain("gap-1") + expect(getByRole("button").className).toContain("items-center") }) }) diff --git a/packages/app-elements/src/ui/composite/Dropdown/Dropdown.test.tsx b/packages/app-elements/src/ui/composite/Dropdown/Dropdown.test.tsx index 9d83ada08..3218c04c7 100644 --- a/packages/app-elements/src/ui/composite/Dropdown/Dropdown.test.tsx +++ b/packages/app-elements/src/ui/composite/Dropdown/Dropdown.test.tsx @@ -33,7 +33,7 @@ describe("Dropdown", () => { diff --git a/packages/app-elements/src/ui/composite/Dropdown/__snapshots__/Dropdown.test.tsx.snap b/packages/app-elements/src/ui/composite/Dropdown/__snapshots__/Dropdown.test.tsx.snap index f04595c6b..40ae52338 100644 --- a/packages/app-elements/src/ui/composite/Dropdown/__snapshots__/Dropdown.test.tsx.snap +++ b/packages/app-elements/src/ui/composite/Dropdown/__snapshots__/Dropdown.test.tsx.snap @@ -8,7 +8,7 @@ exports[`Dropdown > Should be rendering bottom-left 1`] = `
-
@@ -70,15 +66,11 @@ exports[`Dropdown > Should be rendering top-left 1`] = `
-
@@ -115,15 +107,11 @@ exports[`Dropdown > Should be rendering top-right 1`] = `
-
@@ -160,15 +148,11 @@ exports[`Dropdown > Should be rendering with default bottom-right position 1`] =
-