From 0f43867613f9a153382cb3c754eeba77ee8bbe8f Mon Sep 17 00:00:00 2001 From: Dusty Mabe Date: Wed, 18 Mar 2026 12:43:20 -0400 Subject: [PATCH 1/2] support cosa buildextend-nvidiabluefield I had planned not to add this legacy symlink because this is a net new artifact nothing should be using it, but there is logic today [1] that attempts to distinguish between "stable" and "experimental" osbuild artifacts based on the symlink. For now I think we should keep that logic around because there are still a few artifacts that don't use OSBuild. [1] https://github.com/coreos/fedora-coreos-pipeline/blob/0266a4a14b3c9f947255cc5284d399dec4077f03/utils.groovy#L470-L495 --- cmd/coreos-assembler.go | 2 +- src/cmd-buildextend-nvidiabluefield | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) create mode 120000 src/cmd-buildextend-nvidiabluefield diff --git a/cmd/coreos-assembler.go b/cmd/coreos-assembler.go index b7324b77ea..067006272f 100644 --- a/cmd/coreos-assembler.go +++ b/cmd/coreos-assembler.go @@ -14,7 +14,7 @@ import ( // commands we'd expect to use in the local dev path var buildCommands = []string{"init", "fetch", "build", "osbuild", "run", "prune", "clean", "list"} var advancedBuildCommands = []string{"import", "buildfetch", "buildupload", "oc-adm-release", "push-container"} -var buildextendCommands = []string{"aliyun", "applehv", "aws", "azure", "digitalocean", "exoscale", "gcp", "hyperv", "ibmcloud", "kubevirt", "live", "metal", "metal4k", "nutanix", "openstack", "oraclecloud", "qemu", "secex", "virtualbox", "vmware", "vultr"} +var buildextendCommands = []string{"aliyun", "applehv", "aws", "azure", "digitalocean", "exoscale", "gcp", "hyperv", "ibmcloud", "kubevirt", "live", "metal", "metal4k", "nutanix", "nvidiabluefield", "openstack", "oraclecloud", "qemu", "secex", "virtualbox", "vmware", "vultr"} var utilityCommands = []string{"aws-replicate", "coreos-prune", "compress", "copy-container", "diff", "koji-upload", "kola", "push-container-manifest", "remote-build-container", "remote-session", "sign", "tag", "update-variant"} var otherCommands = []string{"shell", "meta"} diff --git a/src/cmd-buildextend-nvidiabluefield b/src/cmd-buildextend-nvidiabluefield new file mode 120000 index 0000000000..887e35adbc --- /dev/null +++ b/src/cmd-buildextend-nvidiabluefield @@ -0,0 +1 @@ +./cmd-osbuild \ No newline at end of file From 6d96e46af4c698da4116e6cc866b9fe2fc879fd6 Mon Sep 17 00:00:00 2001 From: Dusty Mabe Date: Wed, 4 Mar 2026 15:45:15 -0500 Subject: [PATCH 2/2] drop .github/workflows/lints.yml In [1] we configured repo-templates to push the go and shellcheck workflows to the COSA repo. Right now the existing golangci-lint workflow here is failing because of golang versions. Let's just drop the existing lints here prematurely knowing that we are going to move to the new repo-templates provided linters in [2]. [1] https://github.com/coreos/repo-templates/pull/359 [2] https://github.com/coreos/coreos-assembler/pull/4468 --- .github/workflows/lints.yml | 37 ------------------------------------- 1 file changed, 37 deletions(-) delete mode 100644 .github/workflows/lints.yml diff --git a/.github/workflows/lints.yml b/.github/workflows/lints.yml deleted file mode 100644 index 887d4bfd37..0000000000 --- a/.github/workflows/lints.yml +++ /dev/null @@ -1,37 +0,0 @@ -name: lints - -on: - push: - branches: [main] - pull_request: - branches: - - main - - rhcos-* - -permissions: - contents: read - -jobs: - shellcheck: - name: ShellCheck - runs-on: ubuntu-latest - container: quay.io/coreos-assembler/fcos-buildroot:testing-devel - steps: - - name: Install deps - run: yum -y install ShellCheck - - name: Checkout repository - uses: actions/checkout@v3 - - run: make shellcheck - golangci-lint: - name: golangci-lint - runs-on: ubuntu-latest - steps: - - uses: actions/setup-go@v4 - with: - go-version: 1.24 - - uses: actions/checkout@v3 - - name: golangci-lint - uses: golangci/golangci-lint-action@v3 - with: - version: v1.64.4 - args: --timeout=5m