fix: review comments

Author: bradjin8

api/search.py

@@ -172,7 +172,12 @@ def search():
                                 type(e).__name__,
                             )
                             parse_warnings.record_bubble_skipped()
-                        except (json.JSONDecodeError, ValueError):
+                        except (json.JSONDecodeError, TypeError, ValueError) as e:
+                            _logger.warning(
+                                "Failed to decode Bubble from bubbleId:%s: %s",
+                                bid,
+                                e,
+                            )
                             parse_warnings.record_bubble_skipped()
 
                 # Search through composerData
@@ -193,7 +198,12 @@ def search():
                         )
                         parse_warnings.record_composer_skipped()
                         continue
-                    except (json.JSONDecodeError, TypeError, ValueError):
+                    except (json.JSONDecodeError, TypeError, ValueError) as e:
+                        _logger.warning(
+                            "Failed to decode Composer from composerData:%s: %s",
+                            composer_id,
+                            e,
+                        )
                         parse_warnings.record_composer_skipped()
                         continue
                     try:
@@ -289,7 +299,7 @@ def search():
                             composer_id,
                             e,
                         )
-                        parse_warnings.record_composer_skipped()
+                        parse_warnings.record_composer_processing_failure()
 
             except Exception:
                 _logger.exception("Error searching global storage")

models/parse_warnings.py

@@ -9,6 +9,7 @@ class ParseWarningCollector:
 
     composers_skipped: int = 0
     bubbles_skipped: int = 0
+    composers_processing_failed: int = 0
 
     def record_composer_skipped(self, count: int = 1) -> None:
         if count > 0:
@@ -18,9 +19,18 @@ def record_bubble_skipped(self, count: int = 1) -> None:
         if count > 0:
             self.bubbles_skipped += count
 
+    def record_composer_processing_failure(self, count: int = 1) -> None:
+        """Post-parse assembly failed; not a JSON/schema parse skip."""
+        if count > 0:
+            self.composers_processing_failed += count
+
     @property
     def has_warnings(self) -> bool:
-        return self.composers_skipped > 0 or self.bubbles_skipped > 0
+        return (
+            self.composers_skipped > 0
+            or self.bubbles_skipped > 0
+            or self.composers_processing_failed > 0
+        )
 
     def to_api_list(self) -> list[dict]:
         """Structured warnings for JSON API responses (issue #67)."""
@@ -45,6 +55,16 @@ def to_api_list(self) -> list[dict]:
                     f"{n} {noun} could not be loaded due to schema or JSON parse errors"
                 ),
             })
+        if self.composers_processing_failed:
+            n = self.composers_processing_failed
+            noun = "conversation" if n == 1 else "conversations"
+            warnings.append({
+                "type": "processing_error",
+                "count": n,
+                "detail": (
+                    f"{n} {noun} could not be fully assembled after parsing"
+                ),
+            })
         return warnings
 
     def attach_to(self, payload: dict) -> dict:

services/workspace_listing.py

@@ -138,7 +138,7 @@ def _safe_fetchall(query: str, params: tuple = ()) -> list:
                             cid,
                             e,
                         )
-                        parse_warnings.record_composer_skipped()
+                        parse_warnings.record_composer_processing_failure()
             except Exception as e:
                 _logger.error(
                     "Failed to load composer rows from global storage: %s",

services/workspace_tabs.py

@@ -586,7 +586,7 @@ def _safe_fetchall(query: str, params: tuple = ()) -> list:
                     composer_id,
                     e,
                 )
-                parse_warnings.record_composer_skipped()
+                parse_warnings.record_composer_processing_failure()
 
         # Sort tabs by timestamp descending (newest first)
         response["tabs"].sort(key=lambda t: t.get("timestamp") or 0, reverse=True)

templates/index.html

@@ -37,6 +37,11 @@ <h1>Projects</h1>
       fetch('/api/workspaces'),
       fetch('/api/export/state')
     ]);
+    if (!projRes.ok) {
+      document.getElementById('loading').innerHTML =
+        '<p class="text-danger">Failed to load projects.</p>';
+      return;
+    }
     const body = await projRes.json();
     const { projects, warnings } = normalizeWorkspacesResponse(body);
     showIncompleteResultsBanner('parse-warnings-host', warnings);

templates/search.html

@@ -80,6 +80,12 @@ <h1>Search</h1>
 
   try {
     const res = await fetch(`/api/search?q=${encodeURIComponent(query)}&type=${type}`);
+    if (!res.ok) {
+      showIncompleteResultsBanner('parse-warnings-host', []);
+      loading.style.display = 'none';
+      container.innerHTML = '<p class="text-danger">Search failed.</p>';
+      return;
+    }
     const data = await res.json();
     const results = data.results || [];
     showIncompleteResultsBanner('parse-warnings-host', data.warnings);
@@ -110,6 +116,7 @@ <h1>Search</h1>
     }
     container.innerHTML = html;
   } catch (e) {
+    showIncompleteResultsBanner('parse-warnings-host', []);
     loading.style.display = 'none';
     container.innerHTML = '<p class="text-danger">Search failed.</p>';
   }