fix: review comments

Author: bradjin8

tests/test_normalize_file_path.py

@@ -1,22 +1,20 @@
-"""Tests for utils.path_helpers.normalize_file_path.
-
-Covers the shared implementation that was previously duplicated in
-scripts/export.py (closes #46). All call-sites in both the web app and the
-CLI export script now use this single copy.
-
-Edge-case matrix:
-  - file:/// and file:// URI schemes
-  - Percent-encoded characters: spaces (%20), colons (%3A), hashes (%23)
-  - Windows-style drive paths (backslash and forward-slash) on all platforms
-  - Drive-letter lowercasing on win32
-  - Plain POSIX paths pass through unchanged
-  - Empty / None-like input
+"""Tests for utils.path_helpers path/timestamp helpers (closes #46).
+
+Covers ``normalize_file_path`` and ``to_epoch_ms``, both previously duplicated
+in scripts/export.py. All call-sites in the web app and CLI export script now
+use the shared implementations in utils.path_helpers.
+
+Test inventory (this module only): 21 cases — 12 ``normalize_file_path``,
+9 ``to_epoch_ms``. On win32, 2 cases skip (POSIX passthrough in
+``TestNormalizeFilePathPosixPassthrough`` only). A full-suite run may report
+more skips (e.g. ``skipped=4``) from other test modules, not this file.
 """
 
 import sys
 import unittest
+from datetime import datetime, timezone
 
-from utils.path_helpers import normalize_file_path
+from utils.path_helpers import normalize_file_path, to_epoch_ms
 
 
 class TestNormalizeFilePathUriStripping(unittest.TestCase):
@@ -48,9 +46,14 @@ def test_hash_decoded(self) -> None:
     def test_percent_encoded_colon_in_uri_prefix(self) -> None:
         """URI-style /d%3A/... path: %3A is decoded to ':'.
 
-        On win32 the backslash branch is entered (leading slash removed
-        and path lowercased). On other platforms the leading slash prevents
-        the Windows-drive branch, so the path is returned as decoded only.
+        Only test that exercises the leading-``/`` + drive-letter shape end-to-end
+        (Cursor sometimes stores ``/d%3A/...`` URIs). Other drive-path tests use
+        ``D:/...`` or ``D:\\...`` without a leading slash.
+
+        On win32 the win32 branch strips the leading slash, lowercases, and
+        normalises to backslashes. On other platforms the leading ``/`` prevents
+        the ``^[a-zA-Z]:[/\\]`` cross-platform branch in ``path_helpers``, so the
+        path is returned as percent-decoded only (no slash flip / lowercasing).
         """
         out = normalize_file_path("/d%3A/_Work/project")
         self.assertNotIn("%3A", out)
@@ -79,9 +82,8 @@ def test_forward_slash_drive_path_converted(self) -> None:
 
     def test_file_uri_with_windows_drive(self) -> None:
         out = normalize_file_path("file:///C:/Users/Dev/project")
-        self.assertIn("users", out)
-        self.assertIn("dev", out)
-        self.assertTrue(out.startswith("c:"))
+        # file:/// stripped, then same drive-letter branch as D:/ and D:\ inputs.
+        self.assertEqual(out, r"c:\users\dev\project")
 
     def test_mixed_case_drive_lowercased(self) -> None:
         out = normalize_file_path(r"E:\Mixed\Case\Path")
@@ -103,5 +105,37 @@ def test_path_without_scheme_unchanged(self) -> None:
         self.assertEqual(out, "relative/path/file.py")
 
 
+class TestToEpochMs(unittest.TestCase):
+    def test_none_returns_zero(self) -> None:
+        self.assertEqual(to_epoch_ms(None), 0)
+
+    def test_ms_int_passthrough(self) -> None:
+        self.assertEqual(to_epoch_ms(1_700_000_000_000), 1_700_000_000_000)
+
+    def test_seconds_int_converted_to_ms(self) -> None:
+        self.assertEqual(to_epoch_ms(1_700_000_000), 1_700_000_000_000)
+
+    def test_seconds_float_converted_to_ms(self) -> None:
+        self.assertEqual(to_epoch_ms(1_700_000_000.5), 1_700_000_000_500)
+
+    def test_zero_returns_zero(self) -> None:
+        self.assertEqual(to_epoch_ms(0), 0)
+
+    def test_iso8601_zulu(self) -> None:
+        expected = int(
+            datetime(2026, 2, 3, 20, 39, 54, 17_000, tzinfo=timezone.utc).timestamp() * 1000
+        )
+        self.assertEqual(to_epoch_ms("2026-02-03T20:39:54.017Z"), expected)
+
+    def test_numeric_string_already_ms(self) -> None:
+        self.assertEqual(to_epoch_ms("1700000000000"), 1_700_000_000_000)
+
+    def test_numeric_string_seconds(self) -> None:
+        self.assertEqual(to_epoch_ms("1700000000"), 1_700_000_000_000)
+
+    def test_unrecognised_string_returns_zero(self) -> None:
+        self.assertEqual(to_epoch_ms("not-a-timestamp"), 0)
+
+
 if __name__ == "__main__":
     unittest.main()