Fixed #6616 (valueFlowForward: for loop, variable in 3rd expression is changed in loop body)

Author: danmar

lib/valueflow.cpp

@@ -1160,7 +1160,7 @@ static bool valueFlowForward(Token * const               startToken,
                 if (tok3->varId() == varid) {
                     for (std::list<ValueFlow::Value>::const_iterator it = values.begin(); it != values.end(); ++it)
                         setTokenValue(tok3, *it);
-                } else if (Token::Match(tok3, "%oror%|&&|?")) {
+                } else if (Token::Match(tok3, "%oror%|&&|?|;")) {
                     break;
                 }
             }
@@ -1229,7 +1229,7 @@ static bool valueFlowForward(Token * const               startToken,
                             for (it = values.begin(); it != values.end(); ++it)
                                 setTokenValue(condtok, *it);
                         }
-                        if (Token::Match(condtok, "%oror%|&&"))
+                        if (Token::Match(condtok, "%oror%|&&|?|;"))
                             break;
                     }
                     if (settings->debugwarnings)

test/testvalueflow.cpp

@@ -1176,6 +1176,14 @@ class TestValueFlow : public TestFixture {
                "  a = x;\n" // <- x can be 0
                "}\n";
         ASSERT_EQUALS(true, testValueOfX(code, 9U, 0)); // x can be 0 at line 9
+
+        code = "void f(const int a[]) {\n" // #6616
+               "  const int *x = 0;\n"
+               "  for (int i = 0; i < 10; i = *x) {\n" // <- x is not 0
+               "    x = a[i];\n"
+               "  }\n"
+               "}\n";
+        ASSERT_EQUALS(false, testValueOfX(code, 3U, 0));
     }
 
     void valueFlowAfterCondition() {