cleanup dead code, spotted by dmitry-me!

danmar · danmar · commit 406ddc5c1094 · 2017-09-30T23:05:42.000+02:00
diff --git a/lib/utils.h b/lib/utils.h
@@ -82,12 +82,12 @@ inline static const char *getOrdinalText(int i)
 inline static int caseInsensitiveStringCompare(const std::string &lhs, const std::string &rhs)
 {
     if (lhs.size() != rhs.size())
-        return (lhs.size() < rhs.size()) ? -1 : ((lhs.size() == rhs.size()) ? 0 : 1);
+        return (lhs.size() < rhs.size()) ? -1 : 1;
     for (unsigned int i = 0; i < lhs.size(); ++i) {
         int c1 = std::toupper(lhs[i]);
         int c2 = std::toupper(rhs[i]);
         if (c1 != c2)
-            return (c1 < c2) ? -1 : ((c1 == c2) ? 0 : 1);
+            return (c1 < c2) ? -1 : 1;
     }
     return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -82,12 +82,12 @@ inline static const char *getOrdinalText(int i)`
`82`	`82`	`inline static int caseInsensitiveStringCompare(const std::string &lhs, const std::string &rhs)`
`83`	`83`	`{`
`84`	`84`	`if (lhs.size() != rhs.size())`
`85`		`- return (lhs.size() < rhs.size()) ? -1 : ((lhs.size() == rhs.size()) ? 0 : 1);`
	`85`	`+ return (lhs.size() < rhs.size()) ? -1 : 1;`
`86`	`86`	`for (unsigned int i = 0; i < lhs.size(); ++i) {`
`87`	`87`	`int c1 = std::toupper(lhs[i]);`
`88`	`88`	`int c2 = std::toupper(rhs[i]);`
`89`	`89`	`if (c1 != c2)`
`90`		`- return (c1 < c2) ? -1 : ((c1 == c2) ? 0 : 1);`
	`90`	`+ return (c1 < c2) ? -1 : 1;`
`91`	`91`	`}`
`92`	`92`	`return 0;`
`93`	`93`	`}`