CheckCondition::alwaysTrueFalse: Move to normal checking to catch more problems

Author: danmar

lib/checkcondition.h

@@ -51,6 +51,7 @@ class CPPCHECKLIB CheckCondition : public Check {
         checkCondition.oppositeInnerCondition();
         checkCondition.checkIncorrectLogicOperator();
         checkCondition.checkInvalidTestForOverflow();
+        checkCondition.alwaysTrueFalse();
     }
 
     /** @brief Run checks against the simplified token list */
@@ -60,7 +61,6 @@ class CPPCHECKLIB CheckCondition : public Check {
         checkCondition.checkBadBitmaskCheck();
         checkCondition.comparison();
         checkCondition.checkModuloAlwaysTrueFalse();
-        checkCondition.alwaysTrueFalse();
     }
 
     /** mismatching assignment / comparison */

test/testcondition.cpp

@@ -1596,7 +1596,9 @@ class TestCondition : public TestFixture {
               "  A(x++ == 1);\n"
               "  A(x++ == 2);\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:4]: (style) Condition 'x++==2' is always false\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:3]: (style) Condition 'x++==1' is always false\n"
+                      "[test.cpp:4]: (style) Condition 'x++==2' is always false\n",
+                      errout.str());
 
         // Avoid FP when condition comes from macro
         check("void f() {\n"