Fixed #8723: False negative: Same expression with methods

orbitcowboy · orbitcowboy · commit 578d3c3a9338 · 2021-09-17T19:46:46.000+02:00
diff --git a/cfg/qt.cfg b/cfg/qt.cfg
@@ -945,6 +945,7 @@
   <function name="QString::compare">
     <noreturn>false</noreturn>
     <returnValue type="int"/>
+    <const/>
     <use-retval/>
     <leak-ignore/>
     <arg nr="1" direction="in">
diff --git a/test/cfg/qt.cpp b/test/cfg/qt.cpp
@@ -279,6 +279,13 @@ QVector<int>::iterator QVector2()
     return it;
 }
 
+void duplicateExpression_QString_Compare(QString style) //#8723
+{
+	// cppcheck-suppress duplicateExpression
+    if (style.compare( "x", Qt::CaseInsensitive ) == 0 || style.compare( "x", Qt::CaseInsensitive ) == 0)
+    {}
+}
+
 void QStack1(QStack<int> intStackArg)
 {
     for (int i = 0; i <= intStackArg.size(); ++i) {

Original file line number	Diff line number	Diff line change
`@@ -279,6 +279,13 @@ QVector<int>::iterator QVector2()`
`279`	`279`	`return it;`
`280`	`280`	`}`
`281`	`281`
	`282`	`+void duplicateExpression_QString_Compare(QString style) //#8723`
	`283`	`+{`
	`284`	`+ // cppcheck-suppress duplicateExpression`
	`285`	`+ if (style.compare( "x", Qt::CaseInsensitive ) == 0 \|\| style.compare( "x", Qt::CaseInsensitive ) == 0)`
	`286`	`+ {}`
	`287`	`+}`
	`288`	`+`
`282`	`289`	`void QStack1(QStack<int> intStackArg)`
`283`	`290`	`{`
`284`	`291`	`for (int i = 0; i <= intStackArg.size(); ++i) {`