Skip to content

Commit 68ac8a2

Browse files
committed
removed invalid showtime test cases for thread and process executors
1 parent 70d3b1e commit 68ac8a2

2 files changed

Lines changed: 0 additions & 94 deletions

File tree

test/testprocessexecutor.cpp

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,6 @@ class TestProcessExecutor : public TestFixture {
105105
TEST_CASE(one_error_less_files);
106106
TEST_CASE(one_error_several_files);
107107
TEST_CASE(markup);
108-
TEST_CASE(showtime_top5_file);
109-
TEST_CASE(showtime_top5_summary);
110-
TEST_CASE(showtime_file);
111-
TEST_CASE(showtime_summary);
112108
TEST_CASE(showtime_top5_file_j);
113109
TEST_CASE(showtime_top5_summary_j);
114110
TEST_CASE(showtime_file_j);
@@ -246,49 +242,6 @@ class TestProcessExecutor : public TestFixture {
246242

247243
// TODO: provide data which actually shows values above 0
248244

249-
void showtime_top5_file() {
250-
REDIRECT;
251-
check(1, 2, 0,
252-
"int main() {}",
253-
true, SHOWTIME_MODES::SHOWTIME_TOP5_FILE);
254-
const std::string output_s = GET_REDIRECT_OUTPUT;
255-
// for each file: top5 results + overall + empty line
256-
TODO_ASSERT_EQUALS((5 + 1 + 1) * 2, 0, cppcheck::count_all_of(output_s, '\n'));
257-
}
258-
259-
void showtime_top5_summary() {
260-
REDIRECT;
261-
check(1, 2, 0,
262-
"int main() {}",
263-
true, SHOWTIME_MODES::SHOWTIME_TOP5_SUMMARY);
264-
const std::string output_s = GET_REDIRECT_OUTPUT;
265-
// once: top5 results + overall + empty line
266-
TODO_ASSERT_EQUALS(5 + 1 + 1, 0, cppcheck::count_all_of(output_s, '\n'));
267-
// should only report the top5 once
268-
ASSERT(output_s.find("1 result(s)") == std::string::npos);
269-
TODO_ASSERT(output_s.find("2 result(s)") != std::string::npos);
270-
}
271-
272-
void showtime_file() {
273-
REDIRECT;
274-
check(1, 2, 0,
275-
"int main() {}",
276-
true, SHOWTIME_MODES::SHOWTIME_FILE);
277-
const std::string output_s = GET_REDIRECT_OUTPUT;
278-
TODO_ASSERT_EQUALS(2, 0, cppcheck::count_all_of(output_s, "Overall time:"));
279-
}
280-
281-
void showtime_summary() {
282-
REDIRECT;
283-
check(1, 2, 0,
284-
"int main() {}",
285-
true, SHOWTIME_MODES::SHOWTIME_SUMMARY);
286-
const std::string output_s = GET_REDIRECT_OUTPUT;
287-
// should only report the actual summary once
288-
ASSERT(output_s.find("1 result(s)") == std::string::npos);
289-
TODO_ASSERT(output_s.find("2 result(s)") != std::string::npos);
290-
}
291-
292245
void showtime_top5_file_j() {
293246
REDIRECT; // should not cause TSAN failures as the showtime logging is synchronized
294247
check(2, 2, 0,

test/testthreadexecutor.cpp

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,6 @@ class TestThreadExecutor : public TestFixture {
105105
TEST_CASE(one_error_less_files);
106106
TEST_CASE(one_error_several_files);
107107
TEST_CASE(markup);
108-
TEST_CASE(showtime_top5_file);
109-
TEST_CASE(showtime_top5_summary);
110-
TEST_CASE(showtime_file);
111-
TEST_CASE(showtime_summary);
112108
TEST_CASE(showtime_top5_file_j);
113109
TEST_CASE(showtime_top5_summary_j);
114110
TEST_CASE(showtime_file_j);
@@ -246,49 +242,6 @@ class TestThreadExecutor : public TestFixture {
246242

247243
// TODO: provide data which actually shows values above 0
248244

249-
void showtime_top5_file() {
250-
REDIRECT;
251-
check(1, 2, 0,
252-
"int main() {}",
253-
true, SHOWTIME_MODES::SHOWTIME_TOP5_FILE);
254-
const std::string output_s = GET_REDIRECT_OUTPUT;
255-
// for each file: top5 results + overall + empty line
256-
ASSERT_EQUALS((5 + 1 + 1) * 2, cppcheck::count_all_of(output_s, '\n'));
257-
}
258-
259-
void showtime_top5_summary() {
260-
REDIRECT;
261-
check(1, 2, 0,
262-
"int main() {}",
263-
true, SHOWTIME_MODES::SHOWTIME_TOP5_SUMMARY);
264-
const std::string output_s = GET_REDIRECT_OUTPUT;
265-
// once: top5 results + overall + empty line
266-
ASSERT_EQUALS(5 + 1 + 1, cppcheck::count_all_of(output_s, '\n'));
267-
// should only report the top5 once
268-
ASSERT(output_s.find("1 result(s)") == std::string::npos);
269-
ASSERT(output_s.find("2 result(s)") != std::string::npos);
270-
}
271-
272-
void showtime_file() {
273-
REDIRECT;
274-
check(1, 2, 0,
275-
"int main() {}",
276-
true, SHOWTIME_MODES::SHOWTIME_FILE);
277-
const std::string output_s = GET_REDIRECT_OUTPUT;
278-
ASSERT_EQUALS(2, cppcheck::count_all_of(output_s, "Overall time:"));
279-
}
280-
281-
void showtime_summary() {
282-
REDIRECT;
283-
check(1, 2, 0,
284-
"int main() {}",
285-
true, SHOWTIME_MODES::SHOWTIME_SUMMARY);
286-
const std::string output_s = GET_REDIRECT_OUTPUT;
287-
// should only report the actual summary once
288-
ASSERT(output_s.find("1 result(s)") == std::string::npos);
289-
ASSERT(output_s.find("2 result(s)") != std::string::npos);
290-
}
291-
292245
void showtime_top5_file_j() {
293246
REDIRECT; // should not cause TSAN failures as the showtime logging is synchronized
294247
check(2, 2, 0,

0 commit comments

Comments
 (0)