Fixed #9434 (False positive: Out of bounds access when using const pointer)

Author: danmar

lib/valueflow.cpp

@@ -5423,7 +5423,9 @@ static bool isContainerSizeChangedByFunction(const Token *tok, int depth = 20)
         if (arg) {
             if (!arg->isReference() && !addressOf)
                 return false;
-            if (arg->isConst())
+            if (!addressOf && arg->isConst())
+                return false;
+            if (arg->valueType() && arg->valueType()->constness == 1)
                 return false;
             const Scope * scope = fun->functionScope;
             if (scope) {

test/testvalueflow.cpp

@@ -4077,6 +4077,14 @@ class TestValueFlow : public TestFixture {
                "}";
         ASSERT(tokenValues(code, "x . front").empty());
 
+        code = "void g(std::list<int>* const);\n" // #9434
+               "void f() {\n"
+               "  std::list<int> x;\n"
+               "  g(&x);\n"
+               "  x.front();\n"
+               "}";
+        ASSERT(tokenValues(code, "x . front").empty());
+
         code = "void g(const std::list<int>&);\n"
                "void f() {\n"
                "  std::list<int> x;\n"