Skip to content

Commit c31f7c7

Browse files
committed
Improved flags in gui.pro:
- shlwapi.lib is not necessary if dynamic linking is used - Do not define _CRT_SECURE_NO_WARNINGS explicitly, it gets defined anyway.
1 parent 4d01af3 commit c31f7c7

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

gui/gui.pro

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,12 @@ SOURCES += aboutdialog.cpp \
152152
libraryeditargdialog.cpp
153153

154154
win32 {
155-
DEFINES += _CRT_SECURE_NO_WARNINGS
156155
RC_FILE = cppcheck-gui.rc
157156
HEADERS += ../lib/version.h
158-
LIBS += -lshlwapi
157+
contains(LINKCORE, [yY][eE][sS]) {
158+
} else {
159+
LIBS += -lshlwapi
160+
}
159161
}
160162

161163
contains(QMAKE_CC, gcc) {

lib/errorlogger.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,9 @@ class CPPCHECKLIB ErrorLogger {
192192
std::string stringify() const;
193193

194194
unsigned int line;
195+
195196
private:
196197
std::string _file;
197-
198198
};
199199

200200
ErrorMessage(const std::list<FileLocation> &callStack, Severity::SeverityType severity, const std::string &msg, const std::string &id, bool inconclusive);

0 commit comments

Comments
 (0)