Fixed #7363 (valueflowOppositeCondition - if (size1 > size2) ... else if (size1 < size2) ...)

Author: danmar

lib/valueflow.cpp

@@ -733,7 +733,7 @@ static void valueFlowOppositeCondition(SymbolDatabase *symboldatabase, const Set
             const Token *cond2 = tok2->tokAt(4)->astOperand2();
             if (!cond2 || !cond2->isComparisonOp())
                 continue;
-            if (isOppositeCond(false, cpp, cond1, cond2, settings->library.functionpure)) {
+            if (isOppositeCond(true, cpp, cond1, cond2, settings->library.functionpure)) {
                 ValueFlow::Value value(1);
                 value.setKnown();
                 setTokenValue(const_cast<Token*>(cond2), value);

test/testvalueflow.cpp

@@ -1897,6 +1897,12 @@ class TestValueFlow : public TestFixture {
         ASSERT_EQUALS(1, value.intvalue);
         ASSERT(value.isKnown());
 
+        code = "int f(int x) {\n"
+               "  if (x < 2) {}\n"
+               "  else if (x > 2) {}\n" // <- possible value
+               "}";
+        ASSERT(isNotKnownValues(code, ">"));
+
         // function
         code = "int f(int x) { return x + 1; }\n" // <- possible value
                "void a() { f(12); }\b";