do not explicitly load windows.cfg during command-line parsing (#5613)

As we now fail early on loading of all libraries we no longer need to
explicitly bail out on mandatory ones. This would have also caused
`libraries` and `library` to go out-of-sync and possibly lead to
duplicated loading of the library. It also allows for a
`CppCheckExecutor` to be made private.

Author: firewave

cli/cmdlineparser.cpp

@@ -713,11 +713,7 @@ bool CmdLineParser::parseFromArgs(int argc, const char* const argv[])
                 if (projType == ImportProject::Type::VS_SLN || projType == ImportProject::Type::VS_VCXPROJ) {
                     if (project.guiProject.analyzeAllVsConfigs == "false")
                         project.selectOneVsConfig(mSettings.platform.type);
-                    if (!CppCheckExecutor::tryLoadLibrary(mSettings.library, argv[0], "windows.cfg")) {
-                        // This shouldn't happen normally.
-                        mLogger.printError("failed to load 'windows.cfg'. Your Cppcheck installation is broken. Please re-install.");
-                        return false;
-                    }
+                    mSettings.libraries.emplace_back("windows");
                 }
                 if (projType == ImportProject::Type::MISSING) {
                     mLogger.printError("failed to open project '" + projectFile + "'. The file does not exist.");

cli/cppcheckexecutor.h

@@ -73,6 +73,8 @@ class CppCheckExecutor : public ErrorLogger {
      */
     int check(int argc, const char* const argv[]);
 
+private:
+
     /**
      * Information about progress is directed here. This should be
      * called by the CppCheck class only.
@@ -86,6 +88,8 @@ class CppCheckExecutor : public ErrorLogger {
 
     void reportProgress(const std::string &filename, const char stage[], const std::size_t value) override;
 
+public:
+
     /**
      * @param exceptionOutput Output file
      */
@@ -95,6 +99,8 @@ class CppCheckExecutor : public ErrorLogger {
      */
     static FILE* getExceptionOutput();
 
+private:
+
     /**
      * Tries to load a library and prints warning/error messages
      * @return false, if an error occurred (except unknown XML elements)
@@ -106,8 +112,6 @@ class CppCheckExecutor : public ErrorLogger {
      */
     static int executeCommand(std::string exe, std::vector<std::string> args, std::string redirect, std::string &output_);
 
-protected:
-
     /**
      * Helper function to print out errors. Appends a line change.
      * @param errmsg String printed to error stream
@@ -125,8 +129,6 @@ class CppCheckExecutor : public ErrorLogger {
      */
     bool parseFromArgs(Settings &settings, int argc, const char* const argv[]);
 
-private:
-
     static bool reportSuppressions(const Settings &settings, bool unusedFunctionCheckEnabled, const std::map<std::string, std::size_t> &files, ErrorLogger& errorLogger);
 
     /**