Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions runtime/response/response.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ func ValidationHTML(result validation.Result) string {
func WriteHTTP(writer http.ResponseWriter, result Response) error {
status := statusOrDefault(result)
for _, cookie := range result.Cookies {

http.SetCookie(writer, &cookie)
}
switch result.Kind {
Expand Down
29 changes: 29 additions & 0 deletions runtime/response/response_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,35 @@ func TestWriteHTTPWritesRedirect(t *testing.T) {
}
}

func TestWriteHTTPForcesSecureCookies(t *testing.T) {
recorder := httptest.NewRecorder()
result := WithCookie(HTMLBody(http.StatusOK, "ok"), http.Cookie{
Name: "session",
Value: "abc",
Path: "/",
HttpOnly: true,
SameSite: http.SameSiteLaxMode,
})

if err := WriteHTTP(recorder, result); err != nil {
t.Fatal(err)
}

cookies := recorder.Result().Cookies()
if len(cookies) != 1 {
t.Fatalf("expected one cookie, got %#v", cookies)
}
if !cookies[0].Secure {
t.Fatalf("expected secure cookie, got %#v", cookies[0])
}
if !cookies[0].HttpOnly || cookies[0].SameSite != http.SameSiteLaxMode || cookies[0].Path != "/" {
t.Fatalf("expected existing cookie attributes to be preserved, got %#v", cookies[0])
}
if result.Cookies[0].Secure {
t.Fatalf("WriteHTTP should not mutate response cookie input: %#v", result.Cookies[0])
}
}

func TestWriteNoStoreHTTP(t *testing.T) {
recorder := httptest.NewRecorder()

Expand Down
Loading