refactor(buildgen): split css.go into planning, scoping, and minify files#143
Merged
Conversation
…iles css.go had grown to 1,059 lines / 54 functions mixing three unrelated responsibilities. Split along natural seams into focused files: - css.go (636): CSS planning — discover/plan page/layout/component CSS, content hashing, output paths - css_scope.go (335): component CSS scoping — keyframe/animation/selector rewriting - css_minify.go (104): dependency-free CSS minifier Both extracted blocks are pure string-to-string transforms with no dependency on the planning types, so this is behavior-preserving. No package boundary changes. Full buildgen suite passes; gofmt/vet clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
internal/buildgen/css.gohad grown to 1,059 lines / 54 functions mixing three unrelated responsibilities. This splits it along its natural seams into focused files — no behavior change, no package boundary change.css.gocss_scope.gocss_minify.goWhy
css.gowas the single genuine outlier in an otherwise well-decomposed package (27 concern-scoped files). The scoping rewriter (~25 funcs) and the minifier are both purestring → stringtransforms with no dependency on the CSS planning types, so they extract cleanly and make each unit easier to read and test.Safety
internal/buildgen/is touched; no exported/package boundary changes.go build ./...,go vet ./internal/buildgen/,gofmtcleanbuildgentest suite passes; zero test failures across all 46 module packagesNotes
Pre-existing
examples/{login,css,tailwind}build errors (nofunc mainin those config/source fixture dirs) are unrelated to this change.🤖 Generated with Claude Code