From c1e2b534bf3001628095a42c3f1f6a178af0560e Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Mon, 16 Feb 2026 18:13:32 +0100 Subject: [PATCH 1/7] replaced genootschapen with genootschappen. Only thing that remains is migrating the current database so all current genootschapen in the database are correct --- app/models/activity.rb | 2 +- spec/factories/activities.rb | 2 +- spec/models/activity_spec.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/activity.rb b/app/models/activity.rb index 083d59e2..403e9ad7 100644 --- a/app/models/activity.rb +++ b/app/models/activity.rb @@ -35,7 +35,7 @@ class Activity < ApplicationRecord def self.categories %w[algemeen societeit vorming kring - choose ifes ozon disputen genootschapen huizen extern eerstejaars] + choose ifes ozon disputen genootschappen huizen extern eerstejaars] end def full_day? diff --git a/spec/factories/activities.rb b/spec/factories/activities.rb index 63692b97..eb6d4f97 100644 --- a/spec/factories/activities.rb +++ b/spec/factories/activities.rb @@ -11,7 +11,7 @@ end_time { Faker::Time.between(from: 1.day.from_now, to: 2.days.from_now) } category do %w[algemeen societeit vorming kring - choose ifes ozon disputen genootschapen huizen extern eerstejaars].sample + choose ifes ozon disputen genootschappen huizen extern eerstejaars].sample end publicly_visible { false } diff --git a/spec/models/activity_spec.rb b/spec/models/activity_spec.rb index e761f715..33ccc967 100644 --- a/spec/models/activity_spec.rb +++ b/spec/models/activity_spec.rb @@ -180,7 +180,7 @@ let(:record) do build_stubbed(:activity, category: %w[algemeen sociëteit vorming kring - disputen genootschapen huizen extern].sample) + disputen genootschappen huizen extern].sample) end it { expect(record.humanized_category).to eq record.category.capitalize } From c555dd117d083ee434c6caf049d9186c9e790619 Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Mon, 16 Feb 2026 23:46:01 +0100 Subject: [PATCH 2/7] Added database migration --- db/migrate/20260216222433_fix_genootschapen_dyslexia.rb | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 db/migrate/20260216222433_fix_genootschapen_dyslexia.rb diff --git a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb new file mode 100644 index 00000000..8ec31874 --- /dev/null +++ b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb @@ -0,0 +1,9 @@ +class FixGenootschapenDyslexia < ActiveRecord::Migration[7.2] + def up + Activity.where(category: "Genootschapen").update_all(category: "Genootschappen") + end + + def down + Activity.where(category: "Genootschappen").update_all(category: "Genootschapen") + end +end From 82c8b369a29e50941e4f85cae1bb86ee6831e9f2 Mon Sep 17 00:00:00 2001 From: TimonBoer <93792545+TimonBoer@users.noreply.github.com> Date: Mon, 16 Feb 2026 23:58:07 +0100 Subject: [PATCH 3/7] Changed to lowercase Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- db/migrate/20260216222433_fix_genootschapen_dyslexia.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb index 8ec31874..546c8a21 100644 --- a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb +++ b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb @@ -1,9 +1,10 @@ class FixGenootschapenDyslexia < ActiveRecord::Migration[7.2] def up - Activity.where(category: "Genootschapen").update_all(category: "Genootschappen") + Activity.where(category: "genootschapen").update_all(category: "genootschappen") end def down - Activity.where(category: "Genootschappen").update_all(category: "Genootschapen") + Activity.where(category: "genootschappen").update_all(category: "genootschapen") end end +end From 46ef5dda337b529c59721a61701c114a0fb892ee Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Wed, 18 Feb 2026 09:48:40 +0100 Subject: [PATCH 4/7] added database schema --- db/schema.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/schema.rb b/db/schema.rb index 1812a52a..d13e720b 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema[7.1].define(version: 2025_11_03_104056) do +ActiveRecord::Schema[7.2].define(version: 2026_02_16_222433) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" From 5d9adb5cdf4dcf33117abdb573ba558d73cef12d Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Wed, 18 Feb 2026 10:04:00 +0100 Subject: [PATCH 5/7] oops --- db/migrate/20260216222433_fix_genootschapen_dyslexia.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb index 546c8a21..5ca7232a 100644 --- a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb +++ b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb @@ -6,5 +6,4 @@ def up def down Activity.where(category: "genootschappen").update_all(category: "genootschapen") end -end -end +end \ No newline at end of file From a3d0610b086dc25f400f5aeb37fe0fd615cdb9ac Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Wed, 18 Feb 2026 10:37:32 +0100 Subject: [PATCH 6/7] no update_all --- db/migrate/20260216222433_fix_genootschapen_dyslexia.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb index 5ca7232a..964b9646 100644 --- a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb +++ b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb @@ -1,9 +1,13 @@ class FixGenootschapenDyslexia < ActiveRecord::Migration[7.2] def up - Activity.where(category: "genootschapen").update_all(category: "genootschappen") + Activity.where(category: 'genootschapen').find_each do |activity| + activity.update!(category: 'genootschappen') + end end def down - Activity.where(category: "genootschappen").update_all(category: "genootschapen") + Activity.where(category: 'genootschappen').find_each do |activity| + activity.update!(category: 'genootschapen') + end end end \ No newline at end of file From 8840eacb1f353d7b6df34a6197207c409e08ac3f Mon Sep 17 00:00:00 2001 From: Timon Boer Date: Wed, 18 Feb 2026 10:53:38 +0100 Subject: [PATCH 7/7] newline? --- db/migrate/20260216222433_fix_genootschapen_dyslexia.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb index 964b9646..078a9b4f 100644 --- a/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb +++ b/db/migrate/20260216222433_fix_genootschapen_dyslexia.rb @@ -10,4 +10,4 @@ def down activity.update!(category: 'genootschapen') end end -end \ No newline at end of file +end