Skip to content

updated dependencies#6

Merged
SteveDiamond merged 5 commits into
cvxpy:mainfrom
Synphonyte:main
Apr 10, 2026
Merged

updated dependencies#6
SteveDiamond merged 5 commits into
cvxpy:mainfrom
Synphonyte:main

Conversation

@maccesch
Copy link
Copy Markdown
Contributor

@maccesch maccesch commented Apr 10, 2026

Was there a specific reason to have such an old MSRV for a brand new crate or is this just what the AI decided to do? To update all dependencies to their latest and greatest version I had to update the edition to 2024 and MSRV to 1.87

All of this meant changes what lints rustfmt and clippy report. That's why quite a few files have changed.

Also removed deprecated authors entry from Cargo.toml.

Copy link
Copy Markdown
Collaborator

@SteveDiamond SteveDiamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — all CI passes, dependency bumps are clean, and the mechanical rustfmt/clippy changes look correct.

One minor fix needed: in .github/workflows/ci.yml line 108, the job name says Check MSRV (1.85) but the actual toolchain is 1.87. Please update the name to match.

@SteveDiamond
Copy link
Copy Markdown
Collaborator

In terms of MSRV, this package is 100% AI generated excluding user contributions. So not sure why MSRV was set to what it was.

@SteveDiamond SteveDiamond merged commit 0a506bf into cvxpy:main Apr 10, 2026
10 checks passed
@maccesch
Copy link
Copy Markdown
Contributor Author

Oh, sorry about that. I see you already fixed it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants